Skip to content

Commit

Permalink
Merge remote-tracking branch 'origin/CIRCSTORE-540' into CIRCSTORE-540
Browse files Browse the repository at this point in the history
  • Loading branch information
kapil-epam committed Dec 17, 2024
2 parents 29b77fb + dcefa0e commit fc37788
Show file tree
Hide file tree
Showing 2 changed files with 31 additions and 0 deletions.
4 changes: 4 additions & 0 deletions ramls/request.json
Original file line number Diff line number Diff line change
Expand Up @@ -282,6 +282,10 @@
"itemLocationCode": {
"description": "Allow specifying item location when creating title-level requests",
"type": "string"
},
"isDcbReRequestCancellation": {
"description": "Indicates if the request was cancelled during a DCB transaction update. This determines whether the Kafka event will be handled and if an email notification will be sent",
"type": "boolean"
}
},
"additionalProperties": false,
Expand Down
27 changes: 27 additions & 0 deletions src/test/java/org/folio/rest/api/RequestUpdateTriggerTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,14 @@
import io.vertx.core.json.JsonObject;
import io.vertx.sqlclient.Row;
import io.vertx.sqlclient.RowSet;
import lombok.SneakyThrows;

import org.joda.time.DateTime;
import org.joda.time.Seconds;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.CsvSource;

Expand Down Expand Up @@ -55,6 +57,31 @@ void beforeEach() throws MalformedURLException {
StorageTestSuite.deleteAll(requestStorageUrl());
}

@Test
@SneakyThrows
void isDcbReRequestCancellationShouldBePresentAfterRequestUpdated() {
CompletableFuture<JsonObject> future = new CompletableFuture<>();

String id = "3a57dc83-e70d-404b-b1f1-442b88760331";
Request request = new Request()
.withStatus(fromValue(Request.Status.OPEN_NOT_YET_FILLED.toString()));

assertThat(request.getIsDcbReRequestCancellation(), is(nullValue()));

saveRequest(id, request)
.compose(v -> updateRequest(id, request
.withStatus(fromValue(Request.Status.CLOSED_CANCELLED.toString()))
.withIsDcbReRequestCancellation(Boolean.TRUE)))
.compose(v -> getRequest(id))
.onComplete(updatedRequest -> future.complete(updatedRequest.result()));

JsonObject updatedRequest = future.get(5, TimeUnit.SECONDS);

assertThat(updatedRequest.getString("isDcbReRequestCancellation"),
is(notNullValue()));

}

@ParameterizedTest
@CsvSource(value = {
"Open - Awaiting pickup | Closed - Pickup expired",
Expand Down

0 comments on commit fc37788

Please sign in to comment.