Added support for EKS Pod Identity. #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. I should note that the AWS Ruby SDK has support for EKS Pod Identity for more than a year, which makes me wonder if this gem should start to use the SDK directly. @geemus Can you review? |
geemus
approved these changes
Aug 29, 2024
|
I had been wary of trying to put a different interface on top of the SDK and maintain a consistent interface (as well as meaning our performance would be strictly worse), but there are certainly dowsides to the approach we've taken (including things like this). |
|
@y-sugawara-acs Thanks! |
|
Released in v3.25.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to use EKS Pod Identity with fog-aws, so added support for it.
This will resolve #718.
Could anyone please review my code?