-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🎁 Add "dia da consciência negra" - new national holiday in Brazil #558
Conversation
Please let me know if you need anything else from me. Glad to help! |
Vielen Dank! Thanks for your time. |
Hey @paulovitorbal, There are things that need to be done:
|
I will update the translation files accordingly. Until last year (2023) many cities and states had this date as local holliday. In some places it was called The law I mentioned earlier is valid in all cities and states by now, but it does not exclude any municipal or state law that creates a local holiday. So for some cities/states you may have two holidays in the same date with different names. And that's just the chaos of Brazil's law system. And just to give a bit more of context, Zumbi was the last leader of the Palmares quilombo (a community made of slaves that managed to escape from their enslavers). Palmares was the biggest quilombo. He was killed by the government orders at November, 20th. So given all that context, what do you think is the more appropriate name for this holiday? I will make the adjustments as soon as possible. Thanks. |
Lets take this
Thanks for all the information! |
I did the translations using deepl. But I am not sure if deepl understood that Zumbi is a person name and not the noum translation to English. Please let me know if I need to change anything else. I am very glad to help. |
Added the holiday November 20, valid from 2024.
Adding description in other languages
Hey @paulovitorbal, thanks for your work. Yes the translations are, in my opinion, not correct. What if we use these?
|
Sure, I will update the PR accordingly. |
Thanks for your work @paulovitorbal. I will merge it and adjust the translations on main |
Added the holiday November 20, valid from 2024 - valid in all cities and states in Brazil.
Security Vulnerabilities
It's not related to any security vulnerability.
Describing Your Changes
Added a new holiday into the Brazil's calendar:
jollyday-core/src/main/resources/holidays/Holidays_br.xml
This new holiday was introduced in December, 21, 2023. By the national lay 13.759/23 available at: Government official page