Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Breaking: Move British Crown dependencies to own countries #326

Merged
merged 5 commits into from
Sep 27, 2023

Conversation

XSpielinbox
Copy link
Contributor

🐞 closes #270

@derTobsch derTobsch added this to the 0.21.0 milestone Sep 25, 2023
@derTobsch derTobsch force-pushed the fix_crown_dependencies branch 2 times, most recently from 6e4e02b to 4b1a08f Compare September 27, 2023 09:10
@derTobsch
Copy link
Contributor

derTobsch commented Sep 27, 2023

Should we rename the description in the Holidays_gb.xml file from "United Kingdom" to "Great Britain"?

And also change the HolidayCalender entry? Because Locale.UK.getCountry() returns "GB" but it is named "United Kingdom"

@XSpielinbox
Copy link
Contributor Author

XSpielinbox commented Sep 27, 2023

Should we rename the description in the Holidays_gb.xml file from "United Kingdom" to "Great Britain"?

The official name is: "United Kingdom of Great Britain and Northern Ireland"

If we change it, I would change it to that.

See: https://www.iso.org/obp/ui/#iso:code:3166:GB

And also change the HolidayCalender entry? Because Locale.UK.getCountry() returns "GB" but it is named "United Kingdom"

The same applies here in my opinion. This is effectively the question of whether #267 shall also include to rename all country names to there official names. I would personally like that - then one also has the clear baseline there.

@derTobsch
Copy link
Contributor

Should we rename the description in the Holidays_gb.xml file from "United Kingdom" to "Great Britain"?

The official name is: "United Kingdom of Great Britain and Northern Ireland"

If we change it, I would change it to that.

See: https://www.iso.org/obp/ui/#iso:code:3166:GB

And also change the HolidayCalender entry? Because Locale.UK.getCountry() returns "GB" but it is named "United Kingdom"

The same applies here in my opinion. This is effectively the question of whether #267 shall also include to rename all country names to there official names. I would personally like that - then one also has the clear baseline there.

I would leave it like that for now, because "it is commonly known as United Kingdom". In #267 we can take a deeper look.

@derTobsch derTobsch merged commit bcd2b12 into focus-shift:main Sep 27, 2023
9 checks passed
@XSpielinbox XSpielinbox deleted the fix_crown_dependencies branch September 27, 2023 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking: Move British Crown dependencies holidays to own files as they aren't part of Great Britain
2 participants