Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate to enum #1186

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

Migrate to enum #1186

wants to merge 10 commits into from

Conversation

fobo66
Copy link
Owner

@fobo66 fobo66 commented Mar 1, 2025

Use enum instead of string key for the currencies

@fobo66 fobo66 self-assigned this Mar 1, 2025
@fobo66 fobo66 added the enhancement New feature or request label Mar 1, 2025
@fobo66
Copy link
Owner Author

fobo66 commented Mar 3, 2025

Benchmark results:

      605,160   ns          49 allocs    Trace    Method Trace    BestCourseDataSourceBenchmark.findBestSellCurrencies
      607,618   ns          49 allocs    Trace    Method Trace    BestCourseDataSourceBenchmark.findBestBuyCurrencies
Finished 2 tests on moto e13 - 13

@fobo66
Copy link
Owner Author

fobo66 commented Mar 3, 2025

Benchmark with the ScatterSet:

      603,008   ns          40 allocs    Trace    Method Trace    BestCourseDataSourceBenchmark.findBestSellCurrencies
      603,486   ns          40 allocs    Trace    Method Trace    BestCourseDataSourceBenchmark.findBestBuyCurrencies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@fobo66 fobo66

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fobo66