WIP: feat: subscribe new channel, add overflow_url to schedule state #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
smarcet
reviewed
Sep 17, 2024
src/ably.js
Outdated
| @@ -74,6 +74,16 @@ class AblyUpdates { | |||
| }) | |||
| }) | |||
|
|
|||
| channel.subscribe('OVERFLOW', (message) => { | |||
There was a problem hiding this comment.
this is not the correct one please do check the SDS for reference
smarcet
reviewed
Sep 17, 2024
src/ably.js
Outdated
| @@ -74,6 +74,16 @@ class AblyUpdates { | |||
| }) | |||
| }) | |||
|
|
|||
| channel.subscribe('OVERFLOW', (message) => { | |||
| const { data: payload } = message; | |||
| const { event_id, overflow_url } = payload; | |||
There was a problem hiding this comment.
this is not correct is the same payload as data update
plus a new params dictionary where it lives the new attribute
overflow_url
Signed-off-by: Tomás Castillo <[email protected]>
Signed-off-by: Tomás Castillo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: https://tipit.avaza.com/project/view/360253#!tab=task-pane&task=3637562
Signed-off-by: Tomás Castillo [email protected]