Fix leaky diagnostic ignored pragma
          #4588
        
          
      
                
     Merged
            
            
          
      
        
          +2
        
        
          −0
        
        
          
        
      
    
  
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.
  
    
  
    
Ignoring the
-Wconversiondiagnostic inmake_format_argswas leaking out of the header, resulting in that warning being ignored in downstream code that includesfmt/base.h:fmt/include/fmt/base.h
Lines 2823 to 2828 in 9395ef5
We should
push/popthe diagnostics to ensure this is cleaned up (as is done for clang and for GCC options).See this Compiler Explorer reproducer for the problem. You can see that gcc doesn't raise a warning while clang does. Commenting out the
#include <fmt/base.h>restores the correct behaviour.