Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(metadata): explicitly set version #249

Closed
wants to merge 2 commits into from

Conversation

benatouba
Copy link
Contributor

@benatouba benatouba commented Jul 16, 2024

salem.version now correctly reflects the version of the package.

  • closes #xxxx
  • tests added / passed
  • passes git diff upstream/master | flake8 --diff
  • whatsnew entry

salem.utils reads package metadata, but version number was not explicitly set. This resulted in version numbering v0.1+githash for regardless of real release number.

salem.__version__ now correctly reflects the version of the package.
@fmaussion
Copy link
Owner

Thanks! Sorry i missed this. But normally this should be done automatically based on the git tag or commit. Awaiting input from @TimoRoth on how to do this nicely - there must be a good way available somewhere.

@fmaussion
Copy link
Owner

See #250

Thanks for the report!

@fmaussion fmaussion closed this Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants