feat(types): Add type hints and code optimizations #248
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DISCLAIMER: I know this is a lot of changes and might be rejected or a lot of changes requested. But I like to work with typed functions much better and think someone might also benefit from this. This will definitely require additional changes in the future, but I feel it could be a start. All tests passed locally (no google API key).
Python3.8 is almost end-of-life and backwards compatibility to versions before type hints is not a priority any more.
This commit is a start and by no means complete or correct for all instances.
Furthermore, I included code optimizations. These mainly regard raising of exceptions, pytest style tests and some minor refactoring.
git diff upstream/master | flake8 --diff
This is not true for some lines, but most of these would not pass a default flake8 config without the changes.
Formating is done via ruff formatter in black style.