HAR/TU WRF-Mercator #242
Merged
HAR/TU WRF-Mercator #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! Could you make a clean PR without the previous commit? Also this might need some form of testing - but we can think about this later |
benatouba
force-pushed
the
HAR/TU
branch
4 times, most recently
from
b62718f
to
048c423
Compare
fmaussion
reviewed
Jul 9, 2024
salem/sio.py
Outdated
| pargs['lon_0'] = ds.PROJ_CENTRAL_LON | ||
| pargs['center_lon'] = ds.PROJ_CENTRAL_LON | ||
| dx = ds.GRID_DX or ds.DX | ||
| dy = ds.GRID_DY or ds.DY |
There was a problem hiding this comment.
This doesnt look like a good idea because if GRID_DX is not available it will raise an error, not go to ds.DX
|
Did you rebase to latest master? I'm surprised the tests are still failing. |
benatouba
force-pushed
the
HAR/TU
branch
2 times, most recently
from
251d982
to
70ca4c9
Compare
|
Did the rebase now. Adding a fix for your remark next |
Check if GRID_DX/GRID_DY are present in the attributes of files that have proj_envi_string. GRID_DX/GRID_DY should be preferred over DX/DY in this case as they are specifically defined in product generation at least for files generated at TUB. Fixes an issue where the test errors if GRID_DX/GRID_DY are not present.
|
As for testing, i can upload a small test file to the sample data repository |
|
Nah thanks, it's ok like this - I'm still puzzled as to why the tests fail, let's check on master |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for WRF-Mercator projection in TU style products