Notification runtime permission

[sivasubramaniamv]

Fixes #251

Tested on Realme Narzo 30 5G running Android 13

[sivasubramaniamv]

@fm-sys I've done basic permission handling and skipped redirecting the user to the app settings after permission has been denied twice(as the user may find it annoying to see a snackbar every time they open the app).

Please take a look and let me know if any changes/improvements are to be made.

[fm-sys]

Hm, I somehow don't really like it if apps randomly ask for a permission. Two options come to my mind (the second would be the way to go IMHO):

• Add another page to the "onboarding guide" explaining why this permission is necessary and ask for it

  • downside:
    • onboarding gets even longer
    • we would have to show a reduced "upgrade" onboarding to all existing users

• Show an alert dialog asking whether the user wants to receive notifications about completed downloads

  • it should IMHO be shown as soon as the first download is complete
  • users (hopefully) understand why this permission is necessary and are able to choose

Or another variant (similar to no. 2):

• directly ask for the permission as soon as the first download is complete, and show the alert dialog only if permission gets denied

What do you think?

[sivasubramaniamv]

• directly ask for the permission as soon as the first download is complete, and show the alert dialog only if permission gets denied

I think this is the appropriate way.

I have a few questions:

"Show the alert dialog only if permission gets denied" - do you want the alert dialog to be shown when shouldShowRequestPermissionRationale() returns true or as soon as the user denies the permission for the first time?

"As soon as the first download is complete" - after the first file transfer is complete or after the first file is downloaded?

[fm-sys]

"Show the alert dialog only if permission gets denied" - do you want the alert dialog to be shown when shouldShowRequestPermissionRationale() returns true or as soon as the user denies the permission for the first time?

Both options would make sense and are probably pretty equivalent. Or did I missed something?

"As soon as the first download is complete" - after the first file transfer is complete or after the first file is downloaded?

As soon as we try to show the first notification, I guess.

directly ask for the permission as soon as the first download is complete, and show the alert dialog only if permission gets denied

I think this is the appropriate way

OTOH really popular apps like WhatsApp or Signal messager also show the Explanation Dialog before requesting the permission for the first time. IMHO there are good reasons for it...

[sivasubramaniamv]

Both options would make sense and are probably pretty equivalent. Or did I miss something?

If we implement permission handling as suggested in the official Android documentation,

1. Showing the alert dialog when the user denies permission (in the permission launcher result callback) will cause the dialog to be shown as soon as the user presses "don't allow".
2. Showing the alert dialog when shouldShowRequestPermissionRationale() returns true will show the dialog only when the action is performed again (ie: In this case, the action is making a file transfer).

As soon as we try to show the first notification, I guess.

A notification is created for every successfully downloaded file.

If we should show the dialog as soon as we try to show the first notification, we'd have to put it in a method that is called when the file-received event is fired, which would spawn multiple alert dialogs.

OTOH really popular apps like WhatsApp or Signal messager also show the Explanation Dialog before requesting the permission for the first time. IMHO there are good reasons for it.

Sounds reasonable.

[KATHLOY-0709]

Help me to use