-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeplus Support #68
base: main
Are you sure you want to change the base?
Timeplus Support #68
Conversation
I put a 3-min demo video on the doc page https://docs.timeplus.com/flyway |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In TimeplusDatabase
, there is no override for the getUpdateStatement
which is called by Flyway as part of running Repair. I have tried testing this and ran into an error due to the difference syntax with Timeplus and updating.
Is this a known issue and a limitation or something that needs to be implemented?
Hi @WilliamL-RG , thanks for looking into this. Timeplus is similar to ClickHouse, basically is a OLAP focusing on append-only data. I don't see clickhouse flyway extension implemented the In Timeplus Enterprise edition, we built a row-based storage using RocksDB timeplus.com/post/introducing-mutable-streams. In this stream, the update is done by appending a row with same primary key(s) For the flyway metadata table, in this PR, I created it with a ClickHouse MergeTree engine, which should support lightweight update Please advise whether Open for any suggestions |
Hi @WilliamL-RG , I added a commit to override the getUpdateStatement method, please review and advise. |
Timeplus is a simple, powerful, and cost-efficient stream processing platform. This PR added support for both Timeplus Proton (https://github.com/timeplus-io/proton) and Timeplus Enterprise (https://timeplus.com/product). The plugin is tested with Timeplus Enterprise and verified with one of our customers who also purchased flyway.
To test it:
Start a docker instance of Timeplus Enterprise via
Then you can access http://localhost:8000 and create the first user, say admin, with password
changeme
.In the working folder, create flyway.toml
and create some SQL files in the migrations folder.
Download the JDBC jar from https://github.com/timeplus-io/timeplus-native-jdbc/releases/tag/v2.0.7 and put in lib folder.
PS. the code is largely based on the ClickHouse database support, with necessary SQL keywords or data type names changes.