Skip to content
This repository was archived by the owner on Aug 9, 2021. It is now read-only.

WIP Add SIM card PIN policy #457

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

WIP Add SIM card PIN policy #457

wants to merge 2 commits into from

Conversation

@DIOHz0r
Copy link
Contributor

@DIOHz0r DIOHz0r commented Apr 26, 2018 •
edited
Loading

Signed-off-by: Domingo Oropeza [email protected]

Changes description

Add policy to set a PIN code for SIM card

Checklist

Please check if your PR fulfills the following specifications:

  • Tests for the changes have been added
  • Docs have been added/updated

References

Closes #402
Depends on https://github.com/flyve-mdm/android-mdm-agent/issues/388

accesslint[bot]
accesslint bot previously approved these changes Apr 26, 2018
View reviewed changes
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch 2 times, most recently from ac2b588 to 354b149 Compare April 26, 2018 20:40
@ajsb85 ajsb85 requested review from ajsb85 and btry April 26, 2018 20:46
@ajsb85 ajsb85 added the feature label Apr 26, 2018
@ajsb85 ajsb85 added this to the 2.0 milestone Apr 26, 2018
ajsb85
ajsb85 previously approved these changes Apr 26, 2018
View reviewed changes
@btry
Copy link
Contributor

btry commented Apr 26, 2018

A link to the PR for the agent ?

btry
btry previously approved these changes Apr 26, 2018
View reviewed changes
Copy link
Contributor

@btry btry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the agent is ready, then OK to merge.

@btry btry dismissed stale reviews from ajsb85 and themself via f95d4c4 April 29, 2018 12:32
@btry btry force-pushed the feature/402_simcard_pin branch from 354b149 to f95d4c4 Compare April 29, 2018 12:32
@btry btry mentioned this pull request Apr 29, 2018
Merged
ajsb85
ajsb85 previously approved these changes Apr 29, 2018
View reviewed changes
@btry
Copy link
Contributor

btry commented Apr 29, 2018

Is it possible to also create a policy to set the PIN2 ?

@btry btry modified the milestones: 2.0, 2.1 Apr 30, 2018
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch from f95d4c4 to 81cfee2 Compare April 30, 2018 21:28
@DIOHz0r
Copy link
Contributor Author

DIOHz0r commented May 2, 2018 •
edited
Loading

Is it possible to also create a policy to set the PIN2 ?

This policy was added on the last commit

ajsb85
ajsb85 previously approved these changes May 2, 2018
View reviewed changes
btry
btry previously approved these changes May 3, 2018
View reviewed changes
@btry btry changed the title Add SIM card PIN policy WIP (waiting for agent implementation) Add SIM card PIN policy May 3, 2018
@btry
Copy link
Contributor

btry commented May 3, 2018 •
edited by ajsb85
Loading

PR approved, but we need to wait that the agent is ready to handle them.
/cc @rafaelje

@ajsb85 ajsb85 changed the title WIP (waiting for agent implementation) Add SIM card PIN policy WIP Add SIM card PIN policy May 3, 2018
@DIOHz0r DIOHz0r dismissed stale reviews from btry and ajsb85 via e6a52e0 May 10, 2018 14:19
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch from 81cfee2 to e6a52e0 Compare May 10, 2018 14:19
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch from e6a52e0 to e596229 Compare May 14, 2018 21:42
@ajsb85 ajsb85 requested a review from Naylin15 May 22, 2018 10:31
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch from e596229 to 019d239 Compare May 25, 2018 16:28
@DIOHz0r
Copy link
Contributor Author

DIOHz0r commented May 25, 2018

I've been searching on Android's API documentation for the minimum version for this policies but I haven't found any information. @rafaelje, could you give us any reference?

@rafaelje
Copy link

rafaelje commented May 25, 2018

The agent is not ready for this policy, I'm not testing yet but looking the code on the response we can do it sending the PIN information to one intent, so we can do it from API 1 to 27

String ussdCode = "**04*"+oldPin+"*"+newPin+"*"+newPin+"#";
startActivity(new Intent("android.intent.action.CALL", Uri.parse("tel:" + ussdCode)));

https://stackoverflow.com/questions/25784141/android-set-or-reset-sim-card-pin-code-programmatically

@DIOHz0r DIOHz0r changed the title WIP Add SIM card PIN policy Add SIM card PIN policy May 29, 2018
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch from 019d239 to c8c25e0 Compare May 31, 2018 15:19
ajsb85
ajsb85 previously approved these changes Jun 11, 2018
View reviewed changes
@btry btry changed the title Add SIM card PIN policy WIP (2.1) Add SIM card PIN policy Jun 11, 2018
@ajsb85 ajsb85 changed the title WIP (2.1) Add SIM card PIN policy WIP Add SIM card PIN policy Jun 11, 2018
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch 2 times, most recently from dc7d2ce to aa63342 Compare July 13, 2018 19:04
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch 2 times, most recently from 6ef02f4 to b7818a3 Compare July 20, 2018 20:06
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch from b7818a3 to 9357bc2 Compare August 21, 2018 15:19
@ajsb85 ajsb85 closed this Dec 18, 2018
@ajsb85 ajsb85 reopened this Dec 18, 2018
@ajsb85 ajsb85 changed the base branch from develop to features/for_later December 18, 2018 00:25
@btry btry closed this Dec 20, 2018
@btry btry changed the base branch from features/for_later to develop December 20, 2018 17:44
@btry btry reopened this Dec 20, 2018
@ajsb85 ajsb85 assigned DIOHz0r and unassigned DIOHz0r Dec 21, 2018
@DIOHz0r DIOHz0r force-pushed the feature/402_simcard_pin branch from 9357bc2 to 821988e Compare January 3, 2019 20:25
@ajsb85 ajsb85 modified the milestones: 2.1, 3.0 Aug 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Naylin15 Naylin15 Awaiting requested review from Naylin15

3 more reviewers

@ajsb85 ajsb85 ajsb85 left review comments

@btry btry btry left review comments

@accesslint accesslint[bot] accesslint[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@DIOHz0r DIOHz0r

Labels

feature

Projects

None yet

Milestone

3.0

Development

Successfully merging this pull request may close these issues.

Policy to set SIM card PIN

4 participants

@DIOHz0r @btry @rafaelje @ajsb85