Skip to content
This repository has been archived by the owner on Oct 9, 2023. It is now read-only.

Transition to failed state if the k8s resource cannot be created #519

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

pingsutw
Copy link
Member

TL;DR

Related to flyteorg/flyteplugins#310
Mark task state as failed if the k8s resource cannot be created. otherwise, the propeller will keep trying to create CR and task will run forever.

Type

  • Bug Fix
  • Feature
  • Plugin

Are all requirements met?

  • Code completed
  • Smoke tested
  • Unit tests added
  • Code documentation added
  • Any pending items have an associated Issue

Complete description

^^^

Tracking Issue

Follow-up issue

NA

Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
Signed-off-by: Kevin Su <[email protected]>
@pingsutw pingsutw marked this pull request as draft January 20, 2023 09:12
@codecov
Copy link

codecov bot commented Jan 20, 2023

Codecov Report

Merging #519 (47441e4) into master (2014630) will increase coverage by 0.47%.
The diff coverage is 33.33%.

❗ Current head 47441e4 differs from pull request most recent head 0ceabea. Consider uploading reports for the commit 0ceabea to get more accurate results

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant