Fix bug in FlyteDirectory.listdir on local files #2926
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pimdh
requested review from
wild-endeavor,
kumare3,
eapolinario,
pingsutw,
cosmicBboy,
samhita-alla,
thomasjpfan and
Future-Outlier
as code owners
|
Thank you for opening this pull request! 🙌 These tips will help get your PR across the finish line:
|
Fixes flyteorg/flyte#6005 Signed-off-by: Pim de Haan <[email protected]>
Signed-off-by: Pim de Haan <[email protected]>
|
@pimdh , this is pretty cool. Can you fix the lint warning? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tracking issue
Closes flyteorg/flyte#6005
Why are the changes needed?
Fixes bug that makes
FlyteDirectory.listdirreturn file/directory names instead of paths.What changes were proposed in this pull request?
Instead of the file/directory name, return full path.
How was this patch tested?
Added unittest to
tests/flytekit/unit/types/directory/test_listdir.pyCheck all the applicable boxes