Skip to content

Remove Weslaw from Wesley - #769

Open
flyingrobots wants to merge 2 commits into
mainfrom
james/remove-weslaw
Open

Remove Weslaw from Wesley#769
flyingrobots wants to merge 2 commits into
mainfrom
james/remove-weslaw

Conversation

@flyingrobots

@flyingrobots flyingrobots commented Jul 26, 2026

Copy link
Copy Markdown
Owner

What does this PR do?

Removes Weslaw, Law IR, the Weslaw-specific Rust Holmes crate, and their CLI, emitter, schema, fixture, workflow, and release surfaces. The retained extension-generation contract is now a v2 structural provenance seam with no embedded semantic-law input.

Why this approach?

Wesley remains a GraphQL structural compiler. Edict owns executable application semantics, while runtimes and target adapters own their capabilities and target-specific semantics.

Validation

  • cargo xtask preflight
  • Pre-push repository smoke suite

Closes #768

Summary by CodeRabbit

  • New Features

    • Extension-generation contracts and provenance workflows now use the v2 format.
    • Generated metadata focuses on schema and generation details.
  • Bug Fixes

    • Unsupported legacy law commands and emission options now return clear errors.
    • CLI help and documentation accurately reflect the current command surface.
  • Documentation

    • Updated quick-start instructions, CLI references, architecture guidance, and release documentation.
    • Removed obsolete law-authoring, validation, and fixture references.
  • Refactor

    • Rust and TypeScript generation now operate from structural schema inputs without embedded semantic-law artifacts.

@coderabbitai

coderabbitai Bot commented Jul 26, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Weslaw support is removed from the CLI, core contracts, Rust emission, Holmes crate, schemas, fixtures, workflows, release checks, and current documentation. Extension-generation contracts and fixtures are migrated from v1 to v2 without embedded semantic-law data.

Changes

Extension-generation v2

Layer / File(s) Summary
V2 contracts, schemas, fixtures, and tests
crates/wesley-core/..., schemas/..., test/fixtures/extension-generation/...
Extension-generation input, provenance, and review contracts move to v2 and reject semantic-law fields.
Schema-only CLI and emission
crates/wesley-cli/..., crates/wesley-emit-rust/...
Law commands, --law, law metadata, and generated validators are removed; schema-based emission remains.

Repository cleanup

Layer / File(s) Summary
Workspace, Holmes, and release cleanup
crates/wesley-holmes/..., Cargo.toml, xtask/..., .continuum/..., .github/..., test/...
The Rust Holmes crate and Weslaw fixtures are removed, and release/workflow checks no longer reference them.
Architecture and design records
docs/..., README.md, CHANGELOG.md
Current documentation describes domain-neutral compiler evidence and records Weslaw material as retired or superseded.

Estimated code review effort: 4 (Complex) | ~60 minutes

Possibly related PRs

Suggested labels: feature

🚥 Pre-merge checks | ✅ 3 | ❌ 2

❌ Failed checks (2 warnings)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description is too sparse for the repo template; it omits required sections like branch check, changes, risk, backout, testing, and checklist. Fill in the template sections for linked issue, branch check, summary, changes, evidence, risk, backout, testing, merge strategy, and checklist.
Docstring Coverage ⚠️ Warning Docstring coverage is 65.22% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title is concise and accurately summarizes the main change: removing Weslaw from Wesley.
Linked Issues check ✅ Passed The changes align with #768 by removing Weslaw/Law IR surfaces, rewriting docs, and preserving the new v2 structural provenance seam.
Out of Scope Changes check ✅ Passed I don't see clearly unrelated code changes; the diff stays focused on removing Weslaw-related product and documentation surfaces.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch james/remove-weslaw

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown

🔍 The Case of Pull Request #769

Schema Sets

  • ecommerce
  • reference

Schema Set ecommerce

Plain-English Readout

  • Holmes (evidence investigation): The Holmes report is unavailable because the workflow finished without a readable holmes-report.json artifact.
  • Watson (independent verification): The Watson report is unavailable because the workflow finished without a readable watson-report.json artifact.
  • Moriarty (trend forecast): The Moriarty forecast is unavailable because the workflow finished without a readable moriarty-report.json artifact.

Suggested next actions

  1. Regenerate the HOLMES artifacts and make sure holmes-report.json is uploaded before trusting this PR summary.
  2. Regenerate the WATSON artifacts and make sure watson-report.json is uploaded before trusting this PR summary.
  3. Regenerate the MORIARTY artifacts and make sure moriarty-report.json is uploaded before trusting this PR summary.
🕵️ SHA-lock HOLMES full report for ecommerce (click to expand)

Report unavailable for holmes: readable holmes-report.md artifact not found.

🩺 Dr. WATSON full report for ecommerce (click to expand)

Report unavailable for watson: readable watson-report.md artifact not found.

🔮 Professor MORIARTY full report for ecommerce (click to expand)

Report unavailable for moriarty: readable moriarty-report.md artifact not found.


Schema Set reference

Plain-English Readout

  • Holmes (evidence investigation): The Holmes report is unavailable because the workflow finished without a readable holmes-report.json artifact.
  • Watson (independent verification): The Watson report is unavailable because the workflow finished without a readable watson-report.json artifact.
  • Moriarty (trend forecast): The Moriarty forecast is unavailable because the workflow finished without a readable moriarty-report.json artifact.

Suggested next actions

  1. Regenerate the HOLMES artifacts and make sure holmes-report.json is uploaded before trusting this PR summary.
  2. Regenerate the WATSON artifacts and make sure watson-report.json is uploaded before trusting this PR summary.
  3. Regenerate the MORIARTY artifacts and make sure moriarty-report.json is uploaded before trusting this PR summary.
🕵️ SHA-lock HOLMES full report for reference (click to expand)

Report unavailable for holmes: readable holmes-report.md artifact not found.

🩺 Dr. WATSON full report for reference (click to expand)

Report unavailable for watson: readable watson-report.md artifact not found.

🔮 Professor MORIARTY full report for reference (click to expand)

Report unavailable for moriarty: readable moriarty-report.md artifact not found.


📚 Glossary (what the Holmes terms mean)
  • HOLMES: Wesley’s main evidence investigation. It decides whether the cited proof is strong enough to justify shipping this commit.
  • WATSON: An independent verification pass. It checks Holmes’s citations and score math instead of trusting them blindly.
  • MORIARTY: A readiness forecast over time. It is advisory trend analysis, not the release gate itself.
  • Schema coverage score (SCS): How much of the schema has direct supporting evidence across generated artifacts and cited proof.
  • Test confidence index (TCI): How much test evidence exists for constraints, policies, relationships, and operations.
  • Migration risk index (MRI): How risky the schema change is to roll out. Lower is better.
  • Evidence trust: Whether the report is backed by exact citations, whole-file citations, or coarse references. Weak trust means the claim may be directionally right but not specific enough to trust blindly.
  • Citation quality: A count of exact line-span citations versus whole-file or coarse references.
  • ELEMENTARY: Ready to ship based on the current evidence.
  • REQUIRES INVESTIGATION: More work or review is needed before shipping.
  • YOU SHALL NOT PASS: Do not ship this change in its current state.

Machine-readable reports are grouped by schema set in workflow artifacts.


Filed at 221B Repository Street

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

Caution

Some comments are outside the diff and can’t be posted inline due to platform limitations.

⚠️ Outside diff range comments (1)
docs/ARCHITECTURE.md (1)

67-68: 🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Remove dangling RustHolmes edges from the diagram.

After deleting the RustHolmes node, the edges at Lines 99 and 104 still reference it. Remove or rewire those edges so the Mermaid diagram accurately reflects the remaining architecture.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/ARCHITECTURE.md` around lines 67 - 68, Update the Mermaid architecture
diagram to remove or rewire the dangling edges at the RustHolmes references near
the wesley-emit-typescript and wesley-cli nodes, ensuring no remaining diagram
edges reference the deleted RustHolmes node.
🧹 Nitpick comments (1)
crates/wesley-core/tests/extension_generation.rs (1)

115-166: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick win

Missing digest class: projectionRoles.

The test enumerates shape, operations, owner declarations, and settings, but projection_roles is also part of the canonical input and is copied into the review projection. Adding the case keeps this "every input class" claim true.

♻️ Proposed additional case
     let settings_change = input_with(
         shape_ir,
         operations,
         vec![owner],
         b"settings-v2",
         vec!["target-artifact"],
     );
     assert_ne!(base_digest, settings_change.digest().unwrap());

Add before the final block (cloning shape_ir/operations/owner accordingly):

let roles_change = input_with(
    shape_ir.clone(),
    operations.clone(),
    vec![owner.clone()],
    b"settings-v1",
    vec!["target-artifact", "profile"],
);
assert_ne!(base_digest, roles_change.digest().unwrap());
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@crates/wesley-core/tests/extension_generation.rs` around lines 115 - 166, Add
a projection_roles variation to
every_generation_input_class_moves_the_generation_digest using the existing
input_with helper, preserving the other inputs and adding a distinct role such
as "profile" to the target roles. Assert its digest differs from base_digest,
alongside the existing shape, operations, owner, and settings cases.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@docs/design/TEMPLATE.md`:
- Around line 328-329: Replace the undocumented “wesley schema validate” example
with a currently supported schema command, preferably “wesley schema lower”
using the same schema and JSON arguments, or remove that command example while
preserving the valid cargo test command.

In `@docs/ENTRYPOINTS.md`:
- Around line 86-89: Update the LE-binary command entries in ENTRYPOINTS.md to
remove the retired --law options and any remaining metadata claims about
optional law-bundle hashes, matching the current CLI behavior and the
documentation in cli.md. Preserve the supported schema, output, codec-import,
and metadata options.

In `@docs/GUIDE.md`:
- Around line 93-95: Remove the documented Weslaw command entries immediately
above this section, including init-law, the law command family, and emit ...
--law; retain only currently supported command documentation and the existing
Holmes-family guidance.

---

Outside diff comments:
In `@docs/ARCHITECTURE.md`:
- Around line 67-68: Update the Mermaid architecture diagram to remove or rewire
the dangling edges at the RustHolmes references near the wesley-emit-typescript
and wesley-cli nodes, ensuring no remaining diagram edges reference the deleted
RustHolmes node.

---

Nitpick comments:
In `@crates/wesley-core/tests/extension_generation.rs`:
- Around line 115-166: Add a projection_roles variation to
every_generation_input_class_moves_the_generation_digest using the existing
input_with helper, preserving the other inputs and adding a distinct role such
as "profile" to the target roles. Assert its digest differs from base_digest,
alongside the existing shape, operations, owner, and settings cases.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 30f44f6a-3886-414d-91ea-57458903aed1

📥 Commits

Reviewing files that changed from the base of the PR and between 4891a63 and 03271f5.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (138)
  • .continuum/release.yml
  • .github/workflows/rust-native.yml
  • CHANGELOG.md
  • Cargo.toml
  • README.md
  • crates/wesley-cli/src/main.rs
  • crates/wesley-cli/tests/cli.rs
  • crates/wesley-core/README.md
  • crates/wesley-core/src/domain/extension_generation.rs
  • crates/wesley-core/src/domain/law.rs
  • crates/wesley-core/src/domain/mod.rs
  • crates/wesley-core/src/lib.rs
  • crates/wesley-core/tests/extension_generation.rs
  • crates/wesley-core/tests/generated_json_artifacts.rs
  • crates/wesley-core/tests/law_ir.rs
  • crates/wesley-emit-rust/src/lib.rs
  • crates/wesley-holmes/Cargo.toml
  • crates/wesley-holmes/README.md
  • crates/wesley-holmes/src/adapters/mod.rs
  • crates/wesley-holmes/src/application/artifact_locator.rs
  • crates/wesley-holmes/src/application/contract_manifest_ingest.rs
  • crates/wesley-holmes/src/application/evidence_validation.rs
  • crates/wesley-holmes/src/application/law_capability_ingest.rs
  • crates/wesley-holmes/src/application/law_coverage_ingest.rs
  • crates/wesley-holmes/src/application/law_diff_ingest.rs
  • crates/wesley-holmes/src/application/mod.rs
  • crates/wesley-holmes/src/domain/assessment.rs
  • crates/wesley-holmes/src/domain/contract_manifest.rs
  • crates/wesley-holmes/src/domain/diagnostic.rs
  • crates/wesley-holmes/src/domain/evidence.rs
  • crates/wesley-holmes/src/domain/finding.rs
  • crates/wesley-holmes/src/domain/law_capability.rs
  • crates/wesley-holmes/src/domain/law_coverage.rs
  • crates/wesley-holmes/src/domain/law_coverage_gate.rs
  • crates/wesley-holmes/src/domain/law_diff.rs
  • crates/wesley-holmes/src/domain/mod.rs
  • crates/wesley-holmes/src/domain/policy.rs
  • crates/wesley-holmes/src/domain/versioning.rs
  • crates/wesley-holmes/src/lib.rs
  • crates/wesley-holmes/src/ports/mod.rs
  • crates/wesley-holmes/src/reporting/mod.rs
  • crates/wesley-holmes/tests/architecture.rs
  • crates/wesley-holmes/tests/assessment_core.rs
  • crates/wesley-holmes/tests/contract_manifest_ingest.rs
  • crates/wesley-holmes/tests/foundation.rs
  • crates/wesley-holmes/tests/law_capability_ingest.rs
  • crates/wesley-holmes/tests/law_coverage_gate.rs
  • crates/wesley-holmes/tests/law_coverage_ingest.rs
  • crates/wesley-holmes/tests/law_diff_ingest.rs
  • crates/wesley-holmes/tests/policy_core.rs
  • crates/wesley-holmes/tests/semantic_findings.rs
  • crates/wesley-holmes/tests/suppression_abuse.rs
  • docs/ARCHITECTURE.md
  • docs/BEARING.md
  • docs/END_TO_END.md
  • docs/ENTRYPOINTS.md
  • docs/GUIDE.md
  • docs/JEDIT_CAPABILITY_EVIDENCE.md
  • docs/NORTHSTAR.md
  • docs/README.md
  • docs/SDL.md
  • docs/TECHNICAL_TEARDOWN.md
  • docs/architecture/holmes-integration.md
  • docs/design/0019-weslaw-semantic-law-ir/weslaw-semantic-law-ir.md
  • docs/design/0020-holmes-weslaw-assurance-prd-test-plan/holmes-weslaw-assurance-prd-test-plan.md
  • docs/design/0022-justification-graph-assurance-kernel/justification-graph-assurance-kernel.md
  • docs/design/0023-remove-weslaw/SOURCE_remove-weslaw.md
  • docs/design/README.md
  • docs/design/TEMPLATE.md
  • docs/governance/RELEASE_POLICY.md
  • docs/reference/assurance-capability-matrix.md
  • docs/reference/cli.md
  • docs/reference/extension-generation.md
  • docs/topics/README.md
  • docs/topics/assurance-evidence.md
  • docs/topics/native-cli.md
  • docs/topics/weslaw.md
  • docs/truth-manifest.json
  • schemas/README.md
  • schemas/weslaw-v1.schema.json
  • schemas/wesley-contract-bundle-manifest-v1.schema.json
  • schemas/wesley-extension-generation-input-v1.schema.json
  • schemas/wesley-extension-generation-input-v2.schema.json
  • schemas/wesley-generation-provenance-manifest-v2.schema.json
  • schemas/wesley-generation-review-v2.schema.json
  • schemas/wesley-law-diff-v1.schema.json
  • schemas/wesley-law-ir-v1.schema.json
  • test/ci-workflows.bats
  • test/fixtures/extension-generation/input.json
  • test/fixtures/extension-generation/provenance.json
  • test/fixtures/extension-generation/review.json
  • test/fixtures/weslaw/README.md
  • test/fixtures/weslaw/accepted/channel-ttd-protocol-from-directive.weslaw.yaml
  • test/fixtures/weslaw/accepted/channel-ttd-protocol.weslaw.yaml
  • test/fixtures/weslaw/accepted/footprint-replace-range.weslaw.yaml
  • test/fixtures/weslaw/accepted/invariant-translated-evidence.weslaw.yaml
  • test/fixtures/weslaw/accepted/rust-validator-payoff.weslaw.yaml
  • test/fixtures/weslaw/accepted/scalar-semantics.weslaw.yaml
  • test/fixtures/weslaw/accepted/variant-playback-mode.weslaw.yaml
  • test/fixtures/weslaw/contract-bundle-shape.graphql
  • test/fixtures/weslaw/diff/binding-broken.weslaw.yaml
  • test/fixtures/weslaw/diff/ci-semantic-diff.json
  • test/fixtures/weslaw/diff/ci-semantic-diff.md
  • test/fixtures/weslaw/diff/holmes-blade-binding-broken.json
  • test/fixtures/weslaw/diff/new.weslaw.yaml
  • test/fixtures/weslaw/diff/old.weslaw.yaml
  • test/fixtures/weslaw/rejected/duplicate-id.expected.txt
  • test/fixtures/weslaw/rejected/duplicate-id.weslaw.yaml
  • test/fixtures/weslaw/rejected/external-extra-predicate-field.expected.txt
  • test/fixtures/weslaw/rejected/external-extra-predicate-field.weslaw.yaml
  • test/fixtures/weslaw/rejected/field-equals-extra-predicate-field.expected.txt
  • test/fixtures/weslaw/rejected/field-equals-extra-predicate-field.weslaw.yaml
  • test/fixtures/weslaw/rejected/footprint-unknown-cardinality.expected.txt
  • test/fixtures/weslaw/rejected/footprint-unknown-cardinality.weslaw.yaml
  • test/fixtures/weslaw/rejected/raw-expression-invariant.expected.txt
  • test/fixtures/weslaw/rejected/raw-expression-invariant.weslaw.yaml
  • test/fixtures/weslaw/rejected/scalar-forbid-non-integer.expected.txt
  • test/fixtures/weslaw/rejected/scalar-forbid-non-integer.weslaw.yaml
  • test/fixtures/weslaw/rejected/scalar-min-greater-than-max.expected.txt
  • test/fixtures/weslaw/rejected/scalar-min-greater-than-max.weslaw.yaml
  • test/fixtures/weslaw/rejected/scalar-range-on-non-integer.expected.txt
  • test/fixtures/weslaw/rejected/scalar-range-on-non-integer.weslaw.yaml
  • test/fixtures/weslaw/rejected/scalar-unknown-ordering.expected.txt
  • test/fixtures/weslaw/rejected/scalar-unknown-ordering.weslaw.yaml
  • test/fixtures/weslaw/rejected/schema-hash-mismatch.expected.txt
  • test/fixtures/weslaw/rejected/schema-hash-mismatch.weslaw.yaml
  • test/fixtures/weslaw/rejected/unknown-field.expected.txt
  • test/fixtures/weslaw/rejected/unknown-field.weslaw.yaml
  • test/fixtures/weslaw/rejected/unknown-kind.expected.txt
  • test/fixtures/weslaw/rejected/unknown-kind.weslaw.yaml
  • test/fixtures/weslaw/rejected/unresolved-subject.expected.txt
  • test/fixtures/weslaw/rejected/unresolved-subject.weslaw.yaml
  • test/fixtures/weslaw/rejected/wrong-type-optional-sequence.expected.txt
  • test/fixtures/weslaw/rejected/wrong-type-optional-sequence.weslaw.yaml
  • test/release-governance.bats
  • test/weslaw-fixtures.bats
  • wesley.config.json
  • xtask/src/main.rs
💤 Files with no reviewable changes (100)
  • test/fixtures/weslaw/rejected/duplicate-id.expected.txt
  • test/fixtures/weslaw/rejected/scalar-forbid-non-integer.expected.txt
  • test/fixtures/weslaw/diff/binding-broken.weslaw.yaml
  • test/fixtures/weslaw/rejected/scalar-unknown-ordering.expected.txt
  • crates/wesley-holmes/Cargo.toml
  • crates/wesley-holmes/README.md
  • test/fixtures/weslaw/rejected/schema-hash-mismatch.weslaw.yaml
  • test/fixtures/weslaw/rejected/wrong-type-optional-sequence.expected.txt
  • test/fixtures/weslaw/diff/old.weslaw.yaml
  • crates/wesley-holmes/src/reporting/mod.rs
  • docs/topics/native-cli.md
  • test/fixtures/weslaw/rejected/duplicate-id.weslaw.yaml
  • test/fixtures/weslaw/rejected/scalar-forbid-non-integer.weslaw.yaml
  • test/fixtures/weslaw/README.md
  • docs/topics/weslaw.md
  • crates/wesley-core/src/lib.rs
  • test/fixtures/weslaw/rejected/field-equals-extra-predicate-field.expected.txt
  • test/fixtures/weslaw/accepted/channel-ttd-protocol.weslaw.yaml
  • test/fixtures/weslaw/rejected/unknown-kind.expected.txt
  • test/fixtures/weslaw/rejected/scalar-min-greater-than-max.expected.txt
  • test/fixtures/weslaw/accepted/scalar-semantics.weslaw.yaml
  • crates/wesley-holmes/tests/architecture.rs
  • test/fixtures/weslaw/rejected/scalar-range-on-non-integer.expected.txt
  • test/fixtures/weslaw/rejected/scalar-unknown-ordering.weslaw.yaml
  • test/fixtures/weslaw/accepted/invariant-translated-evidence.weslaw.yaml
  • test/fixtures/weslaw/rejected/schema-hash-mismatch.expected.txt
  • test/fixtures/weslaw/accepted/rust-validator-payoff.weslaw.yaml
  • test/fixtures/weslaw/rejected/scalar-min-greater-than-max.weslaw.yaml
  • test/fixtures/weslaw/rejected/raw-expression-invariant.weslaw.yaml
  • schemas/wesley-law-diff-v1.schema.json
  • test/fixtures/weslaw/diff/ci-semantic-diff.md
  • crates/wesley-holmes/tests/contract_manifest_ingest.rs
  • test/fixtures/weslaw/rejected/unknown-field.expected.txt
  • crates/wesley-holmes/src/adapters/mod.rs
  • crates/wesley-holmes/tests/law_coverage_ingest.rs
  • test/fixtures/weslaw/rejected/footprint-unknown-cardinality.weslaw.yaml
  • test/fixtures/weslaw/rejected/external-extra-predicate-field.expected.txt
  • schemas/wesley-contract-bundle-manifest-v1.schema.json
  • test/fixtures/weslaw/rejected/unknown-field.weslaw.yaml
  • test/fixtures/weslaw/diff/holmes-blade-binding-broken.json
  • test/fixtures/weslaw/rejected/unresolved-subject.expected.txt
  • crates/wesley-holmes/tests/semantic_findings.rs
  • test/fixtures/weslaw/diff/ci-semantic-diff.json
  • crates/wesley-holmes/tests/law_coverage_gate.rs
  • docs/truth-manifest.json
  • test/fixtures/weslaw/diff/new.weslaw.yaml
  • test/fixtures/weslaw/rejected/scalar-range-on-non-integer.weslaw.yaml
  • crates/wesley-holmes/tests/suppression_abuse.rs
  • test/fixtures/weslaw/accepted/variant-playback-mode.weslaw.yaml
  • test/fixtures/weslaw/rejected/field-equals-extra-predicate-field.weslaw.yaml
  • crates/wesley-holmes/tests/law_capability_ingest.rs
  • crates/wesley-holmes/tests/law_diff_ingest.rs
  • crates/wesley-holmes/tests/policy_core.rs
  • crates/wesley-holmes/src/application/law_capability_ingest.rs
  • crates/wesley-holmes/tests/assessment_core.rs
  • test/fixtures/weslaw/rejected/external-extra-predicate-field.weslaw.yaml
  • test/fixtures/weslaw/accepted/footprint-replace-range.weslaw.yaml
  • docs/topics/README.md
  • test/fixtures/weslaw/rejected/unresolved-subject.weslaw.yaml
  • test/fixtures/weslaw/rejected/unknown-kind.weslaw.yaml
  • crates/wesley-core/tests/law_ir.rs
  • docs/NORTHSTAR.md
  • test/fixtures/weslaw/accepted/channel-ttd-protocol-from-directive.weslaw.yaml
  • test/fixtures/weslaw/rejected/wrong-type-optional-sequence.weslaw.yaml
  • test/fixtures/weslaw/rejected/footprint-unknown-cardinality.expected.txt
  • crates/wesley-holmes/tests/foundation.rs
  • crates/wesley-holmes/src/domain/law_coverage.rs
  • crates/wesley-holmes/src/lib.rs
  • schemas/weslaw-v1.schema.json
  • crates/wesley-core/src/domain/mod.rs
  • crates/wesley-holmes/src/application/contract_manifest_ingest.rs
  • crates/wesley-holmes/src/application/evidence_validation.rs
  • .github/workflows/rust-native.yml
  • test/weslaw-fixtures.bats
  • wesley.config.json
  • crates/wesley-holmes/src/application/law_coverage_ingest.rs
  • crates/wesley-holmes/src/application/artifact_locator.rs
  • test/fixtures/weslaw/rejected/raw-expression-invariant.expected.txt
  • crates/wesley-holmes/src/domain/contract_manifest.rs
  • schemas/wesley-extension-generation-input-v1.schema.json
  • Cargo.toml
  • crates/wesley-holmes/src/application/mod.rs
  • test/release-governance.bats
  • crates/wesley-holmes/src/domain/law_capability.rs
  • .continuum/release.yml
  • crates/wesley-holmes/src/domain/diagnostic.rs
  • crates/wesley-holmes/src/domain/finding.rs
  • test/ci-workflows.bats
  • schemas/wesley-law-ir-v1.schema.json
  • crates/wesley-holmes/src/application/law_diff_ingest.rs
  • crates/wesley-holmes/src/domain/evidence.rs
  • crates/wesley-holmes/src/ports/mod.rs
  • crates/wesley-holmes/src/domain/law_diff.rs
  • crates/wesley-holmes/src/domain/law_coverage_gate.rs
  • crates/wesley-holmes/src/domain/assessment.rs
  • test/fixtures/weslaw/contract-bundle-shape.graphql
  • crates/wesley-holmes/src/domain/versioning.rs
  • crates/wesley-holmes/src/domain/mod.rs
  • crates/wesley-holmes/src/domain/policy.rs
  • xtask/src/main.rs

Comment thread docs/design/TEMPLATE.md
Comment on lines +328 to +329
cargo test -p wesley-core -- extension_generation
wesley schema validate --schema fixtures/schema.graphql --json

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Replace the undocumented schema validate command.

wesley schema validate is not listed in docs/reference/cli.md or the current root command surface. Use a supported command such as wesley schema lower --schema fixtures/schema.graphql --json, or remove the example.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/design/TEMPLATE.md` around lines 328 - 329, Replace the undocumented
“wesley schema validate” example with a currently supported schema command,
preferably “wesley schema lower” using the same schema and JSON arguments, or
remove that command example while preserving the valid cargo test command.

Comment thread docs/ENTRYPOINTS.md
Comment on lines +86 to 89
wesley emit rust --schema <path> --out <path> [--metadata-out <path>]
wesley emit typescript --schema <path> --out <path> [--metadata-out <path>]
wesley emit le-binary-rust --schema <path> --out <path> [--law <path>] [--metadata-out <path>] [--codec-import <path>]
wesley emit le-binary-typescript --schema <path> --out <path> [--law <path>] [--metadata-out <path>] [--codec-import <path>]

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win

Remove the remaining Weslaw flags and metadata claims.

The adjacent LE-binary commands still document --law, and the metadata capability above still mentions optional law-bundle hashes. docs/reference/cli.md removes --law; update these entries so users are not directed to retired inputs.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/ENTRYPOINTS.md` around lines 86 - 89, Update the LE-binary command
entries in ENTRYPOINTS.md to remove the retired --law options and any remaining
metadata claims about optional law-bundle hashes, matching the current CLI
behavior and the documentation in cli.md. Preserve the supported schema, output,
codec-import, and metadata options.

Comment thread docs/GUIDE.md
Comment on lines +93 to 95
Holmes-family commands still live under `@wesley/holmes`. Use the
[Assurance Capability Matrix](./reference/assurance-capability-matrix.md) for
the shipped/transitional/foundation/concept status of each assurance surface.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎯 Functional Correctness | 🟠 Major | ⚡ Quick win

Remove the still-advertised Weslaw commands from this current guide.

The current command list immediately above still documents init-law, the full law ... family, and emit ... --law, although the removal contract explicitly deletes those surfaces. Users following this guide will invoke unsupported commands, and the current documentation will not satisfy the repository’s docs-runtime-honesty objective.

🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@docs/GUIDE.md` around lines 93 - 95, Remove the documented Weslaw command
entries immediately above this section, including init-law, the law command
family, and emit ... --law; retain only currently supported command
documentation and the existing Holmes-family guidance.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 03271f54f6

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread docs/GUIDE.md
Holmes-family commands still live under `@wesley/holmes`; the Rust foundation
for future Holmes law-assurance ingestion lives in `crates/wesley-holmes` and
does not expose public CLI commands yet. Use the
Holmes-family commands still live under `@wesley/holmes`. Use the

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Remove retired law commands from the guide

Update this migration section’s command list as well: lines 64–91 still direct users to init-law, every law subcommand, and emit ... --law, even though this commit makes those commands/options return usage errors. Anyone using the repository’s orientation guide will therefore be given a nonfunctional fast path immediately after upgrading.

AGENTS.md reference: AGENTS.md:L59-L61

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove Weslaw from Wesley

1 participant