Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed skip in get_skeletons and urljoin used for joining urls #5

Merged
merged 2 commits into from
Mar 10, 2021
Merged

Fixed skip in get_skeletons and urljoin used for joining urls #5

merged 2 commits into from
Mar 10, 2021

Conversation

dokato
Copy link
Contributor

@dokato dokato commented Mar 9, 2021

Fixes #3 and #4.

  • used urllib.parse.urljoin for url parsing
  • in get_skeletons option skips does not return None now but skip wrong body IDs

@dokato dokato requested a review from schlegelp March 9, 2021 20:56
schlegelp
schlegelp requested changes Mar 10, 2021
View reviewed changes
Copy link
Contributor

@schlegelp schlegelp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my comment regarding the progress bar. Looks good otherwise!

dvid/fetch.py Show resolved Hide resolved
@schlegelp schlegelp merged commit 14d84e2 into master Mar 10, 2021
@schlegelp schlegelp deleted the url_fix branch March 10, 2021 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schlegelp schlegelp schlegelp requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fetch_skeletons: don't return empty neurons when no skeleton present
2 participants
@dokato @schlegelp