fix(rumqttd): Make Type::write return correct value for rumqttd (byte…

…beamio#819)
flxo · Mar 12, 2024 · bfc9f9a · bfc9f9a
1 parent 372fe73
commit bfc9f9a
Show file tree

Hide file tree

Showing 4 changed files with 3 additions and 3 deletions.
diff --git a/rumqttd/CHANGELOG.md b/rumqttd/CHANGELOG.md
@@ -25,6 +25,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - MQTT keep alive interval
 - record client id for remote link's span
 - session present flag in connack
+- Make write method return the number of bytes written correctly everywhere
 
 ### Security
 

diff --git a/rumqttd/src/protocol/v4/connect.rs b/rumqttd/src/protocol/v4/connect.rs
@@ -92,7 +92,7 @@ pub fn write(
 
     // update connect flags
     buffer[flags_index] = connect_flags;
-    Ok(len)
+    Ok(1 + count + len)
 }
 
 mod will {

diff --git a/rumqttd/src/protocol/v4/publish.rs b/rumqttd/src/protocol/v4/publish.rs
@@ -63,6 +63,5 @@ pub fn write(publish: &Publish, buffer: &mut BytesMut) -> Result<usize, Error> {
 
     buffer.extend_from_slice(&publish.payload);
 
-    // TODO: Returned length is wrong in other packets. Fix it
     Ok(1 + count + len)
 }
diff --git a/rumqttd/src/protocol/v5/connect.rs b/rumqttd/src/protocol/v5/connect.rs
@@ -122,7 +122,7 @@ pub fn write(
 
     // update connect flags
     buffer[flags_index] = connect_flags;
-    Ok(len)
+    Ok(1 + count + len)
 }
 
 mod will {