runtime/secrets: validate proxy URL scheme and length #1038
+44
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add validation to ProxyURLFromSecret to enforce scheme and length restrictions that were previously enforced by CRD validation in notification-controller's deprecated spec.proxy field. The validation ensures: - Only http or https schemes are accepted - URL length does not exceed 2048 characters The 2048 character limit matches the validation used in notification-controller's spec.address field. Signed-off-by: cappyzawa <[email protected]>
Signed-off-by: cappyzawa <[email protected]>
cappyzawa
requested review from
a team,
hiddeco and
stefanprodan
as code owners
|
@cappyzawa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: fluxcd/notification-controller#1190
While reviewing the negative diff in that PR, I noticed that the
addresskey in the secret referenced by proxySecretRef is missing some validations.