resource: only mark nodes lost that transition from online to offline
#6676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The type of event being processed in post_join_leave() when adjusting monitor->lost (the set of "lost" ranks) is not checked. This means that any time `post_join_leave()` is called, the `lost` idset is adjusted, which is incorrect for all events except "online/offline". The net effect now is that ranks added to the `torpid` group are removed from `lost`, and ranks that become `lively` are added to it. A potentially confusing situation! Only adjust `monitor->lost` when the `monitor->up` idset is being modified, i.e. when `oldset == monitor->up` Fixes flux-framework#6675
Problem: No tests ensures tha torpid/lively events do not affect detection of lost ranks in batch and alloc jobs. Add a set of tests to t2317-resource-shrink.t that ensure a node going from lively to torpid and back again doesn't cause the resources in a subinstance to shrink.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #6676 +/- ##
=======================================
Coverage 83.86% 83.86%
=======================================
Files 534 534
Lines 88929 88930 +1
=======================================
+ Hits 74577 74583 +6
+ Misses 14352 14347 -5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #6675 and adds a set of tests to ensure torpid/lively events don't cause resource removal (shrink).
Thanks for finding this one @garlick!