Changes to add unit test and Internal Testing #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
hariharan-devarajan
commented
Mar 1, 2024
hariharan-devarajan
commented
- Add unit test infrastructure with Catch
- Fix a bug in ctx manager.
- Added Test case for testing data transfer capability.
- Added Test case for testing mdm capability.
- Exported some functions for unit testing.
1. Add unit test infrastructure with Catch 2. Fix a bug in ctx manager. 3. Added Test case for testing data transfer capability. 3. Added Test case for testing mdm capability. 4. Exported some functions for unit testing.
1. Fix Enum for DTLMode 2. Split I/O and locking for consume_w_metadata 3. Comment the STDERR 4. Configurations for DLIO with DYAD
1. Fix Enum for DTLMode 2. Split I/O and locking for consume_w_metadata 3. Comment the STDERR 4. Configurations for DLIO with DYAD
…ane tests for DataSpaces
…kdown of metadata vs data times
…to feature/unittests
hariharan-devarajan
force-pushed
the
feature/unittests
branch
from
c8117ef to
b7fba32
Compare
…to feature/unittests
…Spaces visible to a venv
1. Found that we were doing the check too soon 2. Also for strings > 256 we were failing.
Added unit tests for gen_path_key function.
…to feature/unittests
…to feature/unittests
ilumsden
reviewed
Jun 13, 2024
|
|
||
| find_package(Catch2 REQUIRED) | ||
| find_package(MPI REQUIRED COMPONENTS CXX) | ||
| find_package(dspaces REQUIRED CONFIG) |
There was a problem hiding this comment.
Make Catch2 and dspaces dependencies not required
|
Can we distinguish tests that requires LC environment from general environment? We can discuss the idea. It won't be a blocker for merging this PR. |
|
There are many scripts added. Please add comments at the top of each script describing what it is for, what arguments it takes, and what other scripts it depends on. |
|
We will address the comments in the followup PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.