Skip to content

fix(share_plus): resolve js interop lint and maintain minimum sdk#3846

Merged
vbuberen merged 1 commit into
fluttercommunity:mainfrom
mdmahendri:fix/share-plus-lint
Jun 14, 2026
Merged

fix(share_plus): resolve js interop lint and maintain minimum sdk#3846
vbuberen merged 1 commit into
fluttercommunity:mainfrom
mdmahendri:fix/share-plus-lint

Conversation

@mdmahendri

Copy link
Copy Markdown
Contributor

Description

  • Add invalid_runtime_check_with_js_interop_types suppression in web_share.dart.

Related Issues

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing. i run the flutter test on packages\share_plus\share_plus
  • The analyzer (flutter analyze) does not report any problems on my PR.
D:\...\share_plus\share_plus>flutter test
00:08 +11 ~4: 4 skipped tests.
00:08 +11 ~4: All other tests passed!

D:\...\share_plus\share_plus>flutter analyze
Analyzing share_plus...
No issues found! (ran in 2.4s)

melos run analyze
  └> melos exec -c 5 -- \
       dart analyze . --fatal-infos
     └> RUNNING

$ melos exec
  └> dart analyze . --fatal-infos
     └> RUNNING (in 25 packages)

------------------------------------------------------------------------------------------------------------------------
...
[share_plus]: Analyzing ....
[share_plus]: No issues found!
[share_plus_example]: Analyzing ....
[share_plus_example]: No issues found!
[share_plus_platform_interface]: Analyzing ....
[share_plus_platform_interface]: No issues found!
...

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • No, this is not a breaking change.

- Add `invalid_runtime_check_with_js_interop_types` suppression in `web_share.dart`.
@mdmahendri

Copy link
Copy Markdown
Contributor Author

The failure in the all_plugins/analyze workflow is expected here, as the sensors_plus lint issue is addressed in a separate PR.

@vbuberen vbuberen merged commit 09d75d8 into fluttercommunity:main Jun 14, 2026
13 of 21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants