Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(device_info_plus): fix memory leak when calling DeviceInfoPlugin().macOsInfo #3474

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

codingiran
Copy link

Description

Fix memory leak when call DeviceInfoPlugin().macOsInfo in macOS.

Related Issues

[Bug]: device_info_plus memory leak in macOS

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I titled the PR using Conventional Commits.
  • I did not modify the CHANGELOG.md nor the plugin version in pubspec.yaml files.
  • All existing and new tests are passing.
  • The analyzer (flutter analyze) does not report any problems on my PR.

Breaking Change

Does your PR require plugin users to manually update their apps to accommodate your change?

  • Yes, this is a breaking change (please indicate that with a ! in the title as explained in Conventional Commits).
  • No, this is not a breaking change.

Copy link
Member

@miquelbeltran miquelbeltran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello! Thanks for the contribution. The refactor and the change seem fine to me, but before approving I'd need to test it and also fix CI because seems like something broke with the installation scripts, that may delay this PR for a while.

I've also got a question regarding the use of enum.

@@ -1,23 +1,16 @@
import Foundation

public struct SystemUUID {

public enum SystemUUID {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there a change from struct to enum?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants