Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add barHeight and handleHeight for MaterialVideoProgressBar #826

Merged
merged 4 commits into from
Sep 7, 2024
Merged

Add barHeight and handleHeight for MaterialVideoProgressBar #826

merged 4 commits into from
Sep 7, 2024

Conversation

yujune
Copy link

@yujune yujune commented Apr 3, 2024

Changes being made

  1. Export MaterialVideoProgressBar widget for ChewieController's customControls usage to achieve below ui.
image
  1. Add barHeight and handleHeight properties in MaterialVideoProgressBar widget for height customization.

diegotori
diegotori requested changes Sep 3, 2024
View reviewed changes
Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address what @Ahmadre called out. Thanks.

diegotori
diegotori approved these changes Sep 4, 2024
View reviewed changes
Copy link
Collaborator

@diegotori diegotori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Ahmadre Ahmadre merged commit 7ba611a into fluttercommunity:master Sep 7, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ahmadre Ahmadre Ahmadre approved these changes

@diegotori diegotori diegotori approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yujune @diegotori @Ahmadre @yujunetee