Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated chewie player example for pub.dev #698

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zyllus17
Copy link

Updated the main.dart file with a simpler example and null safety to start working with Chewie player.

Reason for creating this example - Issue #697

If approved this will fix the example mentioned in Issue #697

image

Updated with a simpler example to start working with Chewie player
@zyllus17 zyllus17 changed the title Updated chewie player for pub.dev Updated chewie player example for pub.dev Jan 15, 2023
@diegotori
Copy link
Collaborator

This is not gonna fly in its current form, simply because it will override the more comprehensive example that already exists, which should be retained.

If you want to keep both, you have to incorporate the existing demo app into this PR. Otherwise, we're essentially wiping out useful code in this PR.

@zyllus17
Copy link
Author

I can create a new file with a name chewie_video_player.dart and place the widget in there but then it won't fix the issue of showing the correct example in the pub.dev. Will it be possible to point to a different file, prefereably app.dart from your end so that the correct example can be shown on pub.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants