Support different resolutions of video #492
Open
+254
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegotori
reviewed
Feb 17, 2022
| @@ -179,6 +181,21 @@ class _MaterialControlsState extends State<MaterialControls> | |||
| ); | |||
| } | |||
|
|
|||
| if (chewieController.resolutions != null && | |||
There was a problem hiding this comment.
Replace with if (chewieController.resolutions?.isNotEmpty ?? false) {.
diegotori
reviewed
Feb 17, 2022
| Future<void> _onResolutionTap() async { | ||
| _hideTimer?.cancel(); | ||
|
|
||
| final choosenResolution = await showModalBottomSheet<String>( |
There was a problem hiding this comment.
Rename variable to chosenResolution.
Ahmadre
changed the title
|
Can I use this branch without using master branch? |
|
Hi, how about this feature? @diegotori |
|
@merdweebner are you still actively working on this PR? If so, please re-sync your changes with |
|
Any update? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lib/src/models/video_player_controller_extension.dart