[Fixed] Seeking after video play finished causes inconsistent player state. #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still an issue in the current version? And could you please update your commits to only include relevant files? I do not think we should change the video_player dep away from the officially supported one. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry if there's any mistake in the pull request as this is my first time contributing. For this fix, only this files changes are needed https://github.com/rashedoz/chewie/blob/master/lib/src/material_progress_bar.dart .
The other modifications are related to HLS bitrate change support for flutter video player. I have also modified flutter core video player to support HLS bitrate changes. I have also created a custom chewie control to support bitrate(360p,380p,720p,1080p) change in HLS .
