Add rtl #247
Add rtl #247
Conversation
| ), | ||
| ), | ||
| ); | ||
| } | ||
|
|
||
| List<Widget> createWidget(Color iconColor){ | ||
| Locale myLocale = Localizations.localeOf(context); | ||
| isRtlLanguage( myLocale.languageCode); |
|
Could you explain why this is needed? Your solution is well thought out but misses a few things. In my opinion we should not include localization libraries just to find out if rlt and then reverse the controls. Is there any benefit or real need to reverse the controls? @Ahmadre What's your opinion? |
Rtl is not only related to localizations, but also to accessibility. It would be nice if left-handed people enjoy apps made with chewie. I understand the automatic detection by language, but I would like to have a flag 'rtl' so the concrete app can handle the localization and chewie gets only the flag for the trigger. So, thumbs up from me for this 👍🏼 |
|
@mreslami please re-sync your changes with the latest master changes, then I'll be able to finish reviewing. Thanks in advance. |
Automatic rtl detection and field rtl in chewieController for the display buildBottomBar