Skip to content

Update Arcgis to 4.32.10 #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Update Arcgis to 4.32.10 #89

wants to merge 8 commits into from

Conversation

maxpeters
Copy link
Collaborator

@maxpeters maxpeters commented Apr 29, 2025

Updated ArcGIS to the latest version - 4.32.10.
Replaced deprecated basemap styles and watch function.

Sorry for breaking GitHub with the newly generated files 😄
Best to check out the PR locally and test the changes.
I've listed the most important files below in the description.

Use Basemap V2 Styles:

Use V2 Basemap Styles since v1 is deprecated.

Change files:

  • arcgis_map_sdk_platform_interface/lib/src/models/basemap.dart
  • arcgis_map_sdk_web/lib/src/model_extension.dart

Use ReactiveUtils:

Replace watch with the new reactiveUtils.watch

Important files:

  • arcgis_map_sdk_web/lib/arcgis_map_web_js.dart
  • arcgis_map_sdk_web/lib/src/layer_controller.dart
  • arcgis_map_sdk_web/lib/src/arcgis_map_web_controller.dart
  • arcgis_map_sdk/arcgis_webpack/src/main.js

@maxpeters maxpeters marked this pull request as ready for review April 29, 2025 15:53
@maxpeters maxpeters requested a review from passsy April 29, 2025 15:53
@TarekTolba1
Copy link
Collaborator

Hey @maxpeters & @passsy, thanks for opening this PR and upgrading the Web SDK

I've noticed that you updated the basemap styles to v2.
I've upgraded the native Android & iOS SDKs to v200.7 in #91 & #90. I could see that the web and native sdks now shares the same basemap styles, so I would like to clean up the basemap styles and remove the deprecated values.
I was wondering If I need to wait until you merge this PR or can I go ahead with the changes, and you can resolve any conflicts later.
Do you know when this PR will be ready for merge? If it still needs sometime, I can go ahead with changes.
Let me know what works best for you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants