fix: persistSession parameter does not work as expected
#61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndelanou
force-pushed
the
fix/persist-session
branch
from
cbe9c89 to
491fab2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #55
The current logic handling
persistSessionis wrong:(isSession && persistSession) || (persistSession && !cookie.isExpired())With
persistSessionto true (default behavior), cookies are saved if they are either a session cookie (max-age == null && expires == null) or not expired. Works perfectly ✅When⚠️
persistSessionis false, every cookie is rejected. This is a huge issueI changed the logic in charge of filtering the cookies to be saved.
I also added some tests covering this fix.