feat(rfc_tools): add taxonomy parser, github client, and git lister - #7
Open
jtmcdole wants to merge 3 commits into
Open
feat(rfc_tools): add taxonomy parser, github client, and git lister#7jtmcdole wants to merge 3 commits into
jtmcdole wants to merge 3 commits into
Conversation
jtmcdole
force-pushed
the
pr-2-taxonomy-client
branch
2 times, most recently
from
September 4, 2026 17:13
737fd2a to
67d158c
Compare
jtmcdole
marked this pull request as ready for review
September 4, 2026 17:13
zanderso
reviewed
Sep 4, 2026
| '$rfcDir/', | ||
| ]); | ||
| if (result.exitCode != 0) { | ||
| return const <String>{}; |
Member
There was a problem hiding this comment.
It looks like stdout and stderr from git are getting dropped here. You might want to print them somewhere if the git command fails.
Member
Author
There was a problem hiding this comment.
I'm adding both stdout and stderr for here and the other commands. That way nothing is lost.
jtmcdole
force-pushed
the
pr-2-taxonomy-client
branch
from
September 4, 2026 19:33
67d158c to
305d000
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR 2 of 7 for testing and automation
git ls-treefor better testingStack created with GitHub Stacks CLI • Give Feedback 💬