Skip to content

[ci] remove "read all" permission in reusable_release.yml#11405

Merged
auto-submit[bot] merged 5 commits intoflutter:mainfrom
hannah-hyj:permission-error-2
Mar 31, 2026
Merged

[ci] remove "read all" permission in reusable_release.yml#11405
auto-submit[bot] merged 5 commits intoflutter:mainfrom
hannah-hyj:permission-error-2

Conversation

@hannah-hyj
Copy link
Copy Markdown
Member

@hannah-hyj hannah-hyj commented Mar 31, 2026

it should be override by content: write anyway

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2

@gemini-code-assist
Copy link
Copy Markdown

Note

Gemini is unable to generate a review for this pull request due to the file types involved not being currently supported.

@hannah-hyj hannah-hyj added the CICD Run CI/CD label Mar 31, 2026
@hannah-hyj hannah-hyj changed the title [ci] Manually add "read all" permission to release_from_branches.yml [ci] remove "read all" permission in reusable_release.yml Mar 31, 2026
Copy link
Copy Markdown
Contributor

@chunhtai chunhtai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chunhtai
Copy link
Copy Markdown
Contributor

talked with hannah offline, it seems the job level permission will completely override workflow level permission, so the read-all basically does nothing in theory

@hannah-hyj hannah-hyj added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Mar 31, 2026
@auto-submit auto-submit bot removed the autosubmit Merge PR when tree becomes green via auto submit App label Mar 31, 2026
@auto-submit
Copy link
Copy Markdown
Contributor

auto-submit bot commented Mar 31, 2026

auto label is removed for flutter/packages/11405, Failed to merge flutter/packages/11405 with Pull request flutter/packages/11405 could not be merged: Merge already in progress.

@hannah-hyj hannah-hyj added CICD Run CI/CD autosubmit Merge PR when tree becomes green via auto submit App and removed CICD Run CI/CD labels Mar 31, 2026
@auto-submit auto-submit bot merged commit 4763d4f into flutter:main Mar 31, 2026
81 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autosubmit Merge PR when tree becomes green via auto submit App CICD Run CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants