Skip to content

[google_maps_flutter] Add missing exports #11196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
auto-submit merged 5 commits into from
Mar 30, 2026
Merged

[google_maps_flutter] Add missing exports #11196

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
51a1f07
[google_maps_flutter] Add missing exports
stuartmorgan-g Mar 7, 2026
0728410
Add export unit test
stuartmorgan-g Mar 30, 2026
5b1bab5
Merge branch 'main' into maps-advanced-marker-export
stuartmorgan-g Mar 30, 2026
dee6994
Add new export to test
stuartmorgan-g Mar 30, 2026
e001005
Fix license block format
stuartmorgan-g Mar 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 2.17.0

* Adds missing re-exports of classes related to advanced markers.

## 2.16.0

* Adds `colorScheme` support for web cloud-based maps styling brightness.
Expand Down
1 change: 0 additions & 1 deletion packages/google_maps_flutter/google_maps_flutter/example/lib/advanced_marker_icons.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,6 @@

import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';
import 'package:google_maps_flutter_platform_interface/google_maps_flutter_platform_interface.dart';

import 'page.dart';
import 'place_advanced_marker.dart';
Expand Down
1 change: 0 additions & 1 deletion ...ages/google_maps_flutter/google_maps_flutter/example/lib/advanced_markers_clustering.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import 'dart:math';

import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';
import 'package:google_maps_flutter_platform_interface/google_maps_flutter_platform_interface.dart';

import 'clustering.dart';
import 'page.dart';
Expand Down
1 change: 0 additions & 1 deletion packages/google_maps_flutter/google_maps_flutter/example/lib/collision_behavior.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@ import 'dart:math';

import 'package:flutter/material.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart';
import 'package:google_maps_flutter_platform_interface/google_maps_flutter_platform_interface.dart';

import 'page.dart';
import 'place_advanced_marker.dart';
Expand Down
7 changes: 7 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter/lib/google_maps_flutter.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,21 @@ import 'package:google_maps_flutter_platform_interface/google_maps_flutter_platf

export 'package:google_maps_flutter_platform_interface/google_maps_flutter_platform_interface.dart'
show
AdvancedMarker,
Copy link
Copy Markdown
Contributor

@bparrishMines bparrishMines Mar 18, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need a test like we did for webview_flutter: https://github.com/flutter/packages/blob/main/packages/webview_flutter/webview_flutter/test/webview_flutter_export_test.dart

Copy link
Copy Markdown
Collaborator Author

@stuartmorgan-g stuartmorgan-g Mar 19, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, I'll add that so we don't regress on any future refactorings.

AdvancedMarkerGlyph,
ArgumentCallback,
ArgumentCallbacks,
AssetMapBitmap,
BitmapDescriptor,
BitmapGlyph,
BytesMapBitmap,
CameraPosition,
CameraPositionCallback,
CameraTargetBounds,
CameraUpdate,
Cap,
Circle,
CircleGlyph,
CircleId,
Cluster,
ClusterManager,
Expand All @@ -45,14 +49,17 @@ export 'package:google_maps_flutter_platform_interface/google_maps_flutter_platf
MapStyleException,
MapType,
Marker,
MarkerCollisionBehavior,
MarkerId,
MinMaxZoomPreference,
PatternItem,
PinConfig,
Polygon,
PolygonId,
Polyline,
PolylineId,
ScreenCoordinate,
TextGlyph,
Tile,
TileOverlay,
TileOverlayId,
Expand Down
11 changes: 6 additions & 5 deletions packages/google_maps_flutter/google_maps_flutter/lib/src/google_map.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -402,11 +402,12 @@ class GoogleMap extends StatefulWidget {
///
/// [AdvancedMarker] and [Marker]s classes might not be related to each other
/// in the platform implementation. It's important to set the correct
/// [MarkerType] so that the platform implementation can handle the markers:
/// * If [MarkerType.advancedMarker] is used, all markers must be of type
/// [AdvancedMarker].
/// * If [MarkerType.marker] is used, markers cannot be of type
/// [AdvancedMarker].
/// [GoogleMapMarkerType] so that the platform implementation can handle the
/// markers:
/// * If [GoogleMapMarkerType.advancedMarker] is used, all markers must be of
/// type [AdvancedMarker].
/// * If [GoogleMapMarkerType.marker] is used, markers cannot be of type
/// [AdvancedMarker].
///
/// While some features work with either type, using the incorrect type
/// may result in unexpected behavior.
Expand Down
2 changes: 1 addition & 1 deletion packages/google_maps_flutter/google_maps_flutter/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: google_maps_flutter
description: A Flutter plugin for integrating Google Maps in iOS and Android applications.
repository: https://github.com/flutter/packages/tree/main/packages/google_maps_flutter/google_maps_flutter
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+maps%22
version: 2.16.0
version: 2.17.0

environment:
sdk: ^3.10.0
Expand Down
71 changes: 71 additions & 0 deletions packages/google_maps_flutter/google_maps_flutter/test/google_maps_flutter_export_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,71 @@
// Copyright 2013 The Flutter Authors
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.

// ignore_for_file: unnecessary_statements

import 'package:flutter_test/flutter_test.dart';
import 'package:google_maps_flutter/google_maps_flutter.dart' as main_file;

void main() {
group('google_maps_flutter exports', () {
test(
'ensure google_maps_flutter.dart exports classes from platform interface',
() {
main_file.AdvancedMarker;
main_file.AdvancedMarkerGlyph;
main_file.ArgumentCallback;
main_file.ArgumentCallbacks;
main_file.AssetMapBitmap;
main_file.BitmapDescriptor;
main_file.BitmapGlyph;
main_file.BytesMapBitmap;
main_file.CameraPosition;
main_file.CameraPositionCallback;
main_file.CameraTargetBounds;
main_file.CameraUpdate;
main_file.Cap;
main_file.Circle;
main_file.CircleGlyph;
main_file.CircleId;
main_file.Cluster;
main_file.ClusterManager;
main_file.ClusterManagerId;
main_file.GroundOverlay;
main_file.GroundOverlayId;
main_file.Heatmap;
main_file.HeatmapGradient;
main_file.HeatmapGradientColor;
main_file.HeatmapId;
main_file.HeatmapRadius;
main_file.InfoWindow;
main_file.JointType;
main_file.LatLng;
main_file.LatLngBounds;
main_file.MapBitmapScaling;
main_file.MapColorScheme;
main_file.MapStyleException;
main_file.MapType;
main_file.Marker;
main_file.MarkerCollisionBehavior;
main_file.MarkerId;
main_file.MinMaxZoomPreference;
main_file.PatternItem;
main_file.PinConfig;
main_file.Polygon;
main_file.PolygonId;
main_file.Polyline;
main_file.PolylineId;
main_file.ScreenCoordinate;
main_file.TextGlyph;
main_file.Tile;
main_file.TileOverlay;
main_file.TileOverlayId;
main_file.TileProvider;
main_file.WebCameraControlPosition;
main_file.WebGestureHandling;
main_file.WeightedLatLng;
},
);
});
}
Loading