Skip to content

Comments

[in_app_purchase] Clarify billing dependency handling for Android in example README#11089

Open
khosbilegt wants to merge 3 commits intoflutter:mainfrom
khosbilegt:patch-1
Open

[in_app_purchase] Clarify billing dependency handling for Android in example README#11089
khosbilegt wants to merge 3 commits intoflutter:mainfrom
khosbilegt:patch-1

Conversation

@khosbilegt
Copy link

Clarify misleading billing setup instructions in the Android example for in_app_purchase's README.md (or rather lack of clarification).

Following the instructions of Google Play Billing documentation setup and adding the dependency in build.gradle causes Play Store connectivity issues, and must not be added.

Pre-Review Checklist

If you need help, consider asking for advice on the #hackers-new channel on Discord.

Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the gemini-code-assist bot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

Add important note about common pitfall in dependency management for Google Play Billing.
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request clarifies the Android billing dependency setup in the example's README to prevent users from manually adding a conflicting dependency, which is a valuable addition. The corresponding changelog entry has a minor typo and could be more concise. I've provided a suggestion to address this.

@khosbilegt
Copy link
Author

Had to debug this for a couple hours and found the fix at https://stackoverflow.com/a/70589769/19938854.

LLMs couldn't figure it out. Thought adding it to the README, having it up on pub.dev and having it get indexed would be useful for others.

Accepted Gemini's suggestion for CHANGELOG

Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant