[in_app_purchase] Clarify billing dependency handling for Android in example README#11089
Open
khosbilegt wants to merge 3 commits intoflutter:mainfrom
Open
[in_app_purchase] Clarify billing dependency handling for Android in example README#11089khosbilegt wants to merge 3 commits intoflutter:mainfrom
khosbilegt wants to merge 3 commits intoflutter:mainfrom
Conversation
Add important note about common pitfall in dependency management for Google Play Billing.
There was a problem hiding this comment.
Code Review
This pull request clarifies the Android billing dependency setup in the example's README to prevent users from manually adding a conflicting dependency, which is a valuable addition. The corresponding changelog entry has a minor typo and could be more concise. I've provided a suggestion to address this.
Author
|
Had to debug this for a couple hours and found the fix at https://stackoverflow.com/a/70589769/19938854. LLMs couldn't figure it out. Thought adding it to the README, having it up on pub.dev and having it get indexed would be useful for others. |
Accepted Gemini's suggestion for CHANGELOG Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clarify misleading billing setup instructions in the Android example for in_app_purchase's README.md (or rather lack of clarification).
Following the instructions of Google Play Billing documentation setup and adding the dependency in
build.gradlecauses Play Store connectivity issues, and must not be added.Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3