Skip to content

Conversation

@stuartmorgan-g
Copy link
Collaborator

Updates from 1.8.0 to the just-released 1.9.1.

ExoPlayer 1.9 is no longer trivially mockable, so I followed the team's general guidance to use a real ExoPlayer in a Robolectric test instead of mocking it.

Pre-Review Checklist

Footnotes

  1. Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. 2 3

@stuartmorgan-g
Copy link
Collaborator Author

Oddly we don't seem to have gotten a dependabot PR for the 1.8.0->1.9.0 update.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the androidx.media3:media3-exoplayer dependency to version 1.9.1. As part of this update, the unit tests have been refactored to use Robolectric with real ExoPlayer instances, since mocking is no longer straightforward with the new version. The changes are consistent across the build files, changelog, and tests. My feedback focuses on ensuring proper resource cleanup in the updated tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant