Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/pigeon/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 26.1.5

* [kotlin] Fixes a "bridge method" warning when implementing an event stream handler.

## 26.1.4

* [swift][kotlin] Fixes crash that occurs when an object that is removed from the instance manager
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -186,4 +186,8 @@ abstract class StreamEventsStreamHandler :
.setStreamHandler(internalStreamHandler)
}
}
// Implement methods from EventChannelMessagesPigeonEventChannelWrapper
override fun onListen(p0: Any?, sink: PigeonEventSink<PlatformEvent>) {}

override fun onCancel(p0: Any?) {}
}
2 changes: 1 addition & 1 deletion packages/pigeon/lib/src/generator_tools.dart
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import 'generator.dart';
/// The current version of pigeon.
///
/// This must match the version in pubspec.yaml.
const String pigeonVersion = '26.1.4';
const String pigeonVersion = '26.1.5';

/// Read all the content from [stdin] to a String.
String readStdin() {
Expand Down
4 changes: 4 additions & 0 deletions packages/pigeon/lib/src/kotlin/kotlin_generator.dart
Original file line number Diff line number Diff line change
Expand Up @@ -1234,6 +1234,10 @@ if (wrapped == null) {
EventChannel(messenger, channelName, ${generatorOptions.fileSpecificClassNameComponent}$_pigeonMethodChannelCodec).setStreamHandler(internalStreamHandler)
}
}
// Implement methods from ${generatorOptions.fileSpecificClassNameComponent}PigeonEventChannelWrapper
override fun onListen(p0: Any?, sink: PigeonEventSink<${_kotlinTypeForDartType(func.returnType)}>) {}

override fun onCancel(p0: Any?) {}
}
''');
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -575,6 +575,10 @@ abstract class StreamIntsStreamHandler : EventChannelTestsPigeonEventChannelWrap
.setStreamHandler(internalStreamHandler)
}
}
// Implement methods from EventChannelTestsPigeonEventChannelWrapper
override fun onListen(p0: Any?, sink: PigeonEventSink<Long>) {}

override fun onCancel(p0: Any?) {}
}

abstract class StreamEventsStreamHandler :
Expand All @@ -595,6 +599,10 @@ abstract class StreamEventsStreamHandler :
.setStreamHandler(internalStreamHandler)
}
}
// Implement methods from EventChannelTestsPigeonEventChannelWrapper
override fun onListen(p0: Any?, sink: PigeonEventSink<PlatformEvent>) {}

override fun onCancel(p0: Any?) {}
}

abstract class StreamConsistentNumbersStreamHandler :
Expand All @@ -615,4 +623,8 @@ abstract class StreamConsistentNumbersStreamHandler :
.setStreamHandler(internalStreamHandler)
}
}
// Implement methods from EventChannelTestsPigeonEventChannelWrapper
override fun onListen(p0: Any?, sink: PigeonEventSink<Long>) {}

override fun onCancel(p0: Any?) {}
}
2 changes: 1 addition & 1 deletion packages/pigeon/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: pigeon
description: Code generator tool to make communication between Flutter and the host platform type-safe and easier.
repository: https://github.com/flutter/packages/tree/main/packages/pigeon
issue_tracker: https://github.com/flutter/flutter/issues?q=is%3Aissue+is%3Aopen+label%3A%22p%3A+pigeon%22
version: 26.1.4 # This must match the version in lib/src/generator_tools.dart
version: 26.1.5 # This must match the version in lib/src/generator_tools.dart

environment:
sdk: ^3.9.0
Expand Down