[google_maps_flutter] Replace deprecated methods #10377
Open
+14
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Replaces `Color` methods that were deprecated in Flutter with their recommended replacement. - Replaces `cloudMapId` with the newer `mapId` from the platform interface configuration object (the former is now just a deprecated passthrough to the latter). Part of flutter/flutter#159739
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request correctly replaces several deprecated APIs. The use of deprecated Color methods has been updated to their modern equivalents, and cloudMapId has been replaced with the current mapId. The changes are correct and align with the goal of keeping the codebase up-to-date. I have one minor suggestion to make the changelog entry more comprehensive.
| @@ -1,3 +1,7 @@ | |||
| ## 0.5.14+3 | |||
|
|
|||
| * Replaces uses of deprecated `Color` properties. | |||
There was a problem hiding this comment.
The changelog entry is a bit incomplete. It should also mention the replacement of the deprecated cloudMapId property to fully capture the changes in this PR.
Suggested change
| * Replaces uses of deprecated `Color` properties. | |
| * Replaces uses of deprecated `Color` properties and `cloudMapId`. |
mdebbar
approved these changes
Nov 7, 2025
| @@ -1,3 +1,7 @@ | |||
| ## 0.5.14+3 | |||
|
|
|||
| * Replaces uses of deprecated `Color` properties. | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Colormethods that were deprecated in Flutter with their recommended replacement.cloudMapIdwith the newermapIdfrom the platform interface configuration object (the former is now just a deprecated passthrough to the latter).Part of flutter/flutter#159739
Pre-Review Checklist
[shared_preferences]pubspec.yamlwith an appropriate new version according to the pub versioning philosophy, or I have commented below to indicate which version change exemption this PR falls under1.CHANGELOG.mdto add a description of the change, following repository CHANGELOG style, or I have commented below to indicate which CHANGELOG exemption this PR falls under1.///).Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2 ↩3