Skip to content
This repository has been archived by the owner on Aug 20, 2021. It is now read-only.

null safety migration, add desktop runners #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

domesticmouse
Copy link

@domesticmouse domesticmouse commented Mar 24, 2021

PTAL @Hixie. This update is required for https://github.com/miickel/flutter_particle_clock to depend on this repo again.

For context: miickel/flutter_particle_clock#10

@domesticmouse domesticmouse changed the title dart migrate + add desktop null safety migration, add desktop runners Mar 24, 2021
Copy link

@gspencergoog gspencergoog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

32384589-a60f0e74-c078-11e7-9bc1-e5b5287aea9d

@@ -148,7 +128,7 @@
isa = PBXProject;
attributes = {
LastUpgradeCheck = 1020;
ORGANIZATIONNAME = "The Chromium Authors";
ORGANIZATIONNAME = "";

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be set to "The Flutter Authors" or something?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the unadulterated output of flutter create, and it has been like this for a couple of stable releases IIRC.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, no worries, then.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants