Backend-specific EmbedderTestBackingStoreProducers #56638
Merged
+674
−535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbracken
force-pushed
the
refactor-embedder-test-backingstore-producer
branch
from
744da5a
to
cb479bc
Compare
|
|
||
| GrMtlTextureInfo skia_texture_info; | ||
| skia_texture_info.fTexture.reset(SkCFSafeRetain(texture_info.texture)); | ||
| GrBackendTexture backend_texture = GrBackendTextures::MakeMtl( |
There was a problem hiding this comment.
Nothing to do here, but all these tests/test harness that use Skia types directly like this will need to either be rewritten or deleted next year
There was a problem hiding this comment.
Yup. I suspect there's a non-zero amount of Skia-specific code in the embedder_unittests source too for that matter.
Refactoring all this stuff out into backend-specific classes hopefully makes either of those options easier.
cbracken
force-pushed
the
refactor-embedder-test-backingstore-producer
branch
3 times, most recently
from
314b7d9
to
0c6c4d3
Compare
cbracken
commented
Nov 16, 2024
| // Ideally this would be set in the constructor, however we can't do that | ||
| // without introducing different constructors depending on different graphics | ||
| // APIs, which is a bit ugly. | ||
| test_egl_context_ = std::move(context); |
There was a problem hiding this comment.
Turns out introducing different constructors is less ugly.
cbracken
force-pushed
the
refactor-embedder-test-backingstore-producer
branch
from
0c6c4d3
to
c82578b
Compare
cbracken
commented
Nov 16, 2024
| #ifdef SHELL_ENABLE_GL | ||
| std::shared_ptr<TestEGLContext> egl_context_ = nullptr; | ||
| #endif | ||
|
|
There was a problem hiding this comment.
Last ifdef of the file, gone.
Extracts backend-specific subclasses of EmbedderTestBackingStoreProducer for OpenGL, Metal, Software, and Vulkan. Issue: flutter/flutter#158998
cbracken
force-pushed
the
refactor-embedder-test-backingstore-producer
branch
from
c82578b
to
fce8036
Compare
cbracken
added
the
autosubmit
auto-submit
bot
removed
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
Nov 16, 2024
github-merge-queue bot
pushed a commit
to flutter/flutter
that referenced
this pull request
Nov 16, 2024
…159017) flutter/engine@f238321...98c3b7f 2024-11-16 [email protected] Backend-specific EmbedderTestBackingStoreProducers (flutter/engine#56638) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC [email protected],[email protected] on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extracts backend-specific subclasses of EmbedderTestBackingStoreProducer for OpenGL, Metal, Software, and Vulkan.
Issue: flutter/flutter#158998
Pre-launch Checklist
///).If you need help, consider asking for advice on the #hackers-new channel on Discord.