Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use updated gni source list #56627

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

kjlubick
Copy link
Contributor

In https://skia-review.googlesource.com/c/skia/+/884096, Skia broke up this gni file list into Ganesh and Graphite specific code. Since Flutter only needs Ganesh sources, this can be made more precise.

Pre-launch Checklist

  • [ x ] I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • [ x ] I read the Tree Hygiene wiki page, which explains my responsibilities.
  • [ x ] I read and followed the Flutter Style Guide and the C++, Objective-C, Java style guides.
  • I listed at least one issue that this PR fixes in the description above.
  • [ x ] I added new tests to check the change I am making or feature I am adding, or the PR is test-exempt. See testing the engine for instructions on writing and running engine tests.
  • [ x ] I updated/added relevant documentation (doc comments with ///).
  • [ x ] I signed the CLA.
  • [ x ] All existing and new tests are passing.

If you need help, consider asking for advice on the #hackers-new channel on Discord.

@kjlubick kjlubick requested a review from flar November 15, 2024 20:20
Copy link
Contributor

@flar flar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants