Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iOS: Migrate FlutterEngineGroup to ARC #55503

Merged
merged 5 commits into from
Sep 30, 2024
Merged

iOS: Migrate FlutterEngineGroup to ARC #55503

merged 5 commits into from
Sep 30, 2024

Commits on Sep 30, 2024

  1. iOS: Migrate FlutterEngineGroup to ARC 

    This migrates FlutterEngineGroup to automatic reference counting. It
also migrates `enginesCreatedCount` from an ivar to property syntax.

In a followup cleanup, I'll look at migrating engine from
`NSMutableArray<NSValue*>` to a weak pointer array.

Issue: flutter/flutter#137801
    @cbracken
    cbracken committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    99f6a34 View commit details
    Browse the repository at this point in the history

  2. Copy semantics for DartProject property

    @cbracken
    cbracken committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    2f12a4b View commit details
    Browse the repository at this point in the history

  3. Make enginesCreatedCount uint

    @cbracken
    cbracken committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    675c2b2 View commit details
    Browse the repository at this point in the history

  4. strong->copy

    @cbracken
    cbracken committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    0824051 View commit details
    Browse the repository at this point in the history

  5. Add bridge TODO

    @cbracken
    cbracken committed Sep 30, 2024
    Configuration menu
    Copy the full SHA
    20f12fc View commit details
    Browse the repository at this point in the history