[DisplayList] Optimize draws of simple shapes expressed as paths #55376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we also start removing some of the optimization logic from the dispatcher: https://github.com/flutter/engine/blob/main/impeller/display_list/dl_dispatcher.cc#L993-L1024 I see there are other places that flow through SimplifyOrDrawPath so we probably can't remove tht yet, but it will be simpler long term if the dispatcher is dumber. |
|
Based on the conversation I had with Jim the other day, I think we are going to abandon this as tiny changes to rendering results were observed with the Skia backend. Am I thinking of the right bug? |
|
Correct. We'll revisit this later when we have only 1 backend. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes flutter/flutter#151849
Originally part of #53622 which had to be reverted due to incompatible scuba changes. This part was split out as the likely culprit in the scuba failures and eventually an issue was found with the way the original code was written which failed to properly handle unclosed rectangles. This version fixes that bug.