Skip to content
This repository was archived by the owner on Feb 25, 2025. It is now read-only.

[DisplayList] Optimize draws of simple shapes expressed as paths #55376

Closed
wants to merge 1 commit into from

Conversation

flar
Copy link
Contributor

@flar flar commented Sep 24, 2024

Fixes flutter/flutter#151849

Originally part of #53622 which had to be reverted due to incompatible scuba changes. This part was split out as the likely culprit in the scuba failures and eventually an issue was found with the way the original code was written which failed to properly handle unclosed rectangles. This version fixes that bug.

@jonahwilliams
Copy link
Contributor

Can we also start removing some of the optimization logic from the dispatcher: https://github.com/flutter/engine/blob/main/impeller/display_list/dl_dispatcher.cc#L993-L1024

I see there are other places that flow through SimplifyOrDrawPath so we probably can't remove tht yet, but it will be simpler long term if the dispatcher is dumber.

@chinmaygarde
Copy link
Member

Based on the conversation I had with Jim the other day, I think we are going to abandon this as tiny changes to rendering results were observed with the Skia backend. Am I thinking of the right bug?

@flar
Copy link
Contributor Author

flar commented Sep 30, 2024

Correct. We'll revisit this later when we have only 1 backend.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DisplayList] DrawPath does not recognize or optimize rects, ovals, or rrects
3 participants