Skip to content

Increase WebDriver timeouts to address integration test flakiness #9475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
elliette merged 2 commits into from
Oct 21, 2025
Merged

Increase WebDriver timeouts to address integration test flakiness #9475

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7daf6a
Increase timeout limits to address flakes
elliette Oct 16, 2025
0bac06a
Update comment
elliette Oct 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions packages/devtools_app/test_driver/integration_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,9 +16,23 @@ const _goldensDirectoryPath = 'integration_test/test_infra/goldens';
const _failuresDirectoryPath = '$_goldensDirectoryPath/failures';
const _defaultDiffPercentage = 1.0;
const _defaultDiffTolerance = 0.003;
// The following timeouts were copied from
// https://developer.mozilla.org/en-US/docs/Web/WebDriver/Reference/Timeouts
const _defaultWebDriverPageLoadTimeoutInMins = 5;
const _defaultWebDriverScriptTimeoutInSeconds = 30;

Future<void> main() async {
final driver = await FlutterDriver.connect();

// Double the WebDriver timeout limits to handle test flakiness.
// See https://github.com/flutter/devtools/issues/9474
await driver.webDriver.timeouts.setScriptTimeout(
const Duration(seconds: _defaultWebDriverScriptTimeoutInSeconds * 2),
);
await driver.webDriver.timeouts.setPageLoadTimeout(
const Duration(minutes: _defaultWebDriverPageLoadTimeoutInMins * 2),
);

await integrationDriver(
driver: driver,
onScreenshot:
Expand Down
Loading