Repository navigation
[url_launcher] Implement supportsMode - #1184
Merged
seungsoo47 merged 2 commits intoOct 15, 2026
Merged
seungsoo47 merged 2 commits into
seungsoo47 merged 2 commits into
Conversation
launch() always opens the URL in an external application through the view app control, but without a supportsMode override the platform interface default reported only platformDefault as supported, so supportsLaunchMode(LaunchMode.externalApplication) returned false. Report externalApplication as supported, like url_launcher_linux. Upstream: flutter/packages#5211 (a0ed43580e)
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
JSUYA
approved these changes
Oct 15, 2026
Member
There was a problem hiding this comment.
This note still says that only platformDefault is supported. Could you update it to include externalApplication so it matches the behavior reported by supportsMode?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
launch() always opens the URL in an external application through the view app control, but without a supportsMode override the platform interface default reported only platformDefault as supported, so supportsLaunchMode(LaunchMode.externalApplication) returned false. Report externalApplication as supported, like url_launcher_linux.
Upstream: flutter/packages#5211 (a0ed43580e)