Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: use pagefind for searching (resolves #262, #227, #153) #263

Merged
merged 4 commits into from
Apr 24, 2024
Merged

feat: use pagefind for searching (resolves #262, #227, #153) #263

merged 4 commits into from
Apr 24, 2024

Conversation

jobara
Copy link
Member

@jobara jobara commented Apr 24, 2024

Resolves #262
Resolves #227
Resolves #153

  • Switched to using Pagefind for searches
  • Removed old search and related tests
  • Updates implementation of mini search to just do a form submission and include a button
  • Minor refactoring of styles related to contrast themes and updates related to Pagefind integration

greatislander
greatislander requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Links within search results lack sufficient contrast in the hover state:

Search results for the term 'UIO', showing 11 results for UIO, the first result under the heading Subcomponents has a link which appears with black text on a black background in its hover state

greatislander
greatislander requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@greatislander greatislander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be good to add a bit of space between the Pagefind "load more results" button and the footer.

@greatislander greatislander added the enhancement New feature or request label Apr 24, 2024
@greatislander greatislander merged commit f9ed3a6 into fluid-project:main Apr 24, 2024
6 checks passed
duhrer added a commit to duhrer/infusion-docs that referenced this pull request Apr 29, 2024
@duhrer
fluid-projectGH-263: Removed 'old' search dependencies and code now t…
7fe4ccd 
…hat pagefind is in use.
amb26 added a commit that referenced this pull request Apr 29, 2024
@amb26
Merge branch 'GH-265' into main
8f3812f 
* GH-265:
  GH-263: Removed 'old' search dependencies and code now that pagefind is in use.
  GH-265: Restored 'octicons' on heading hover.
@jobara jobara mentioned this pull request Jul 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@greatislander greatislander greatislander approved these changes

Assignees

@jobara jobara

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
2 participants
@jobara @greatislander