Skip to content

Conversation

onedr0p
Copy link

@onedr0p onedr0p commented Sep 29, 2025

Important

After this is merged and charts are released you might need to make the packages public from here

I also bumped some deps as well.

Fixes: #550

Added conditions for pushing charts to GHCR and updated action versions.

Signed-off-by: Devin Buhl <[email protected]>
@onedr0p
Copy link
Author

onedr0p commented Sep 29, 2025

cc @patrick-stephens

@patrick-stephens
Copy link
Contributor

I'm going to delegate to @stevehipwell for his expertise here plus I know he has some much improved CI he wants to push :)

@onedr0p
Copy link
Author

onedr0p commented Sep 30, 2025

@patrick-stephens Ah, yes. I did just discover his comment here. However I think merging this is a good stop-gap until more work can be put into getting his action working here, or unless @stevehipwell wants to supersede this PR with his own using his action in the meantime.

@stevehipwell
Copy link
Collaborator

@onedr0p thanks for the PR. I'm planning on adding my PR soon, but this may be a good stopgap.

@patrick-stephens could you check if the OCI packages are public? Once they are I'll manually upload a chart version that we can test before making a decision on merging this change.

@patrick-stephens
Copy link
Contributor

No packages exist yet so they are not public, assuming we are pushing to ghcr.io/${{ github.repository }} which would map to ghcr.io/fluent/helm-charts.

We can change the package visibility easily enough, I'm not sure what it will default to initially and we may need to link it to this repo potentially - sometimes the action does that for you automatically.

Copy link
Contributor

@patrick-stephens patrick-stephens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bit surprised we have to update the actions, I'm guessing we should have a dependency PR for that somewhere.

@stevehipwell
Copy link
Collaborator

Bit surprised we have to update the actions, I'm guessing we should have a dependency PR for that somewhere.

It looks like Dependabot has been ignored so it's stopped checking, I've just manually re-triggered it.

Copy link
Collaborator

@stevehipwell stevehipwell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes don't look right here, has there been a merge issue?

@onedr0p
Copy link
Author

onedr0p commented Oct 16, 2025

@stevehipwell what do you mean, it looks normal to me?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Provide OCI Artifact helm chart release

3 participants