-
Notifications
You must be signed in to change notification settings - Fork 484
ci: push charts to GHCR #641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Added conditions for pushing charts to GHCR and updated action versions. Signed-off-by: Devin Buhl <[email protected]>
I'm going to delegate to @stevehipwell for his expertise here plus I know he has some much improved CI he wants to push :) |
@patrick-stephens Ah, yes. I did just discover his comment here. However I think merging this is a good stop-gap until more work can be put into getting his action working here, or unless @stevehipwell wants to supersede this PR with his own using his action in the meantime. |
@onedr0p thanks for the PR. I'm planning on adding my PR soon, but this may be a good stopgap. @patrick-stephens could you check if the OCI packages are public? Once they are I'll manually upload a chart version that we can test before making a decision on merging this change. |
No packages exist yet so they are not public, assuming we are pushing to We can change the package visibility easily enough, I'm not sure what it will default to initially and we may need to link it to this repo potentially - sometimes the action does that for you automatically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bit surprised we have to update the actions, I'm guessing we should have a dependency PR for that somewhere.
It looks like Dependabot has been ignored so it's stopped checking, I've just manually re-triggered it. |
Signed-off-by: Pat <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The changes don't look right here, has there been a merge issue?
@stevehipwell what do you mean, it looks normal to me? |
Important
After this is merged and charts are released you might need to make the packages public from here
I also bumped some deps as well.
Fixes: #550