config: error configure_plugins_type on invalid properties #10296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stoksc
requested review from
edsiper,
leonardo-albertovich,
fujimotos and
koleini
as code owners
stoksc
force-pushed
the
stoksc/invalid-input-property
branch
from
82e5741 to
ea1ea67
Compare
stoksc
force-pushed
the
stoksc/invalid-input-property
branch
from
511c426 to
e85d7f7
Compare
stoksc
force-pushed
the
stoksc/invalid-input-property
branch
2 times, most recently
from
e85d7f7 to
ffffa03
Compare
stoksc
force-pushed
the
stoksc/invalid-input-property
branch
2 times, most recently
from
677fc73 to
df46f10
Compare
|
Nope, it passes, I approve it, tag it if possible and ping @edsiper so he merges it when he considers it appropriate. |
7 tasks
stoksc
commented
May 19, 2025
stoksc
force-pushed
the
stoksc/invalid-input-property
branch
from
f1a0272 to
48f4886
Compare
|
thanks for this contribution. Code looks good to me. To get this merged, please split the commits per interface, now there is 1 commit but 2 interfaces are being touched:
something like:
|
After this change, when a plugin configuration contains an invalid property, `configure_plugins_type` returns an error which ultimately crashes fluentbit, instead of only printing an error log and continuing on. The change also fixes a small issue where `name` was printed by `flb_error` after it was freed. To properly test this change and get the test to pass with `-DSANITIZE_ADDRESS=On` on all platforms, I had to update `configure_plugins_type` to free objects that it fails to instantiate. Signed-off-by: Bradley Laney <[email protected]>
stoksc
force-pushed
the
stoksc/invalid-input-property
branch
from
48f4886 to
ab5e219
Compare
…invalid properties Signed-off-by: Bradley Laney <[email protected]>
stoksc
force-pushed
the
stoksc/invalid-input-property
branch
from
ab5e219 to
1d00d34
Compare
|
thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this change, when a plugin configuration contains an invalid property,
configure_plugins_typereturns an error which ultimately crashes fluentbit, instead of only printing an error log and continuing on. The change also fixes a small issue wherenamewas printed byflb_errorafter it was freed. To properly test this change and get the test to pass with-DSANITIZE_ADDRESS=Onon all platforms, I had to updateconfigure_plugins_typeto free objects that it fails to instantiate.Enter
[N/A]in the box, if an item is not applicable to your change.Testing
Before we can approve your change; please submit the following in a comment:
Added tests, so the configuration files and outputs can be found there.
If this is a change to packaging of containers or native binaries then please confirm it works for all targets.
ok-package-testlabel to test for all targets (requires maintainer to do).Documentation
Backporting
Fluent Bit is licensed under Apache 2.0, by submitting this pull request I understand that this code will be released under the terms of that license.