Skip to content

doc: administration: configuring-fluent-bit: Replace incorrect WITH_TRACE build option FLB_TRACE - #2653

Merged
eschabell merged 3 commits into
fluent:masterfrom
RaJiska:fix-trace-option
Aug 2, 2026
Merged

doc: administration: configuring-fluent-bit: Replace incorrect WITH_TRACE build option FLB_TRACE#2653
eschabell merged 3 commits into
fluent:masterfrom
RaJiska:fix-trace-option

Conversation

@RaJiska

@RaJiska RaJiska commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

The documented WITH_TRACE option is used only for Monkey library. Fluent Bit is built with traces using the FLB_TRACE option as documented in the "Build and install" section.

Summary by CodeRabbit

  • Documentation
    • Updated logging configuration guidance to accurately describe the build option required to enable trace log output in both classic and YAML configuration modes.
    • Reordered service configuration entries for improved clarity.

RaJiska added 2 commits August 2, 2026 14:41
…ion-file: Fix incorrect `WITH_TRACE` with `FLB_TRACE`

The documented `WITH_TRACE` option is used only for Monkey library. Fluent Bit
is built with traces using the `FLB_TRACE` option as documented in the
"Build and install" section.

Signed-off-by: Ra'Jiska <dodo.lasticot@gmail.com>
…ix incorrect `WITH_TRACE` with `FLB_TRACE`

The documented `WITH_TRACE` option is used only for Monkey library. Fluent Bit
is built with traces using the `FLB_TRACE` option as documented in the
"Build and install" section.

Signed-off-by: Ra'Jiska <dodo.lasticot@gmail.com>
@RaJiska
RaJiska requested review from a team and eschabell as code owners August 2, 2026 06:48
@coderabbitai

coderabbitai Bot commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: d1671589-d799-4b52-83b3-35a2634a5075

📥 Commits

Reviewing files that changed from the base of the PR and between b441d8e and 2d1c7b0.

📒 Files selected for processing (1)
  • administration/configuring-fluent-bit/classic-mode/configuration-file.md
🚧 Files skipped from review as they are similar to previous changes (1)
  • administration/configuring-fluent-bit/classic-mode/configuration-file.md

📝 Walkthrough

Walkthrough

The change updates trace logging build-option references in the classic-mode and YAML Service documentation. It also reorders classic-mode Service entries and updates the dns.mode wording.

Changes

Service configuration documentation

Layer / File(s) Summary
Trace build-option references and Service entry order
administration/configuring-fluent-bit/classic-mode/configuration-file.md, administration/configuring-fluent-bit/yaml/service-section.md
The documentation now uses FLB_TRACE for trace logging. The classic-mode Service entries are reordered, and the dns.mode wording is updated.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: waiting-on-review

Suggested reviewers: eschabell

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly identifies the documentation change from WITH_TRACE to FLB_TRACE in Fluent Bit administration documentation.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@administration/configuring-fluent-bit/classic-mode/configuration-file.md`:
- Line 24: Update the dns.mode description in the configuration table so its
second sentence reads as a complete sentence with “It” as the subject and uses
the hyphenated “per-plugin” modifier.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: c7a42389-9646-4df4-8d40-40a96632d27f

📥 Commits

Reviewing files that changed from the base of the PR and between 45e40b8 and b441d8e.

📒 Files selected for processing (1)
  • administration/configuring-fluent-bit/classic-mode/configuration-file.md

Comment thread administration/configuring-fluent-bit/classic-mode/configuration-file.md Outdated
…ion-file: Clean up Service key table

- Sort the Service section key table alphabetically by key name, from
  `coro_stack_size` through `windows.maxstdio`. Row content is unchanged;
  this is a pure reorder that matches the ordering already used by the
  YAML `service-section.md` table.
- Remove the italics wrapping from the `FLB_TRACE` code span in the
  `log_level` row, so it renders as a plain code span and matches how
  `FLB_TRACE` is written on the YAML `service-section.md` and
  `build-and-install.md` pages.
- Reword the `dns.mode` description so the second sentence has an explicit
  subject and uses the hyphenated "per-plugin" modifier.

Signed-off-by: Eric D. Schabell <eric@schabell.org>
@eschabell eschabell self-assigned this Aug 2, 2026
@eschabell eschabell added the 5.0.9 label Aug 2, 2026

@eschabell eschabell left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@RaJiska thanks for the docs PR, approved and merging this.

@eschabell
eschabell merged commit 4331784 into fluent:master Aug 2, 2026
8 checks passed
@RaJiska
RaJiska deleted the fix-trace-option branch August 2, 2026 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants