-
Notifications
You must be signed in to change notification settings - Fork 545
in_tail: Add data reliability note #2310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
WalkthroughAdded documentation to the Tail input describing data reliability and recovery semantics (at-least-once delivery, restart resumption from last committed checkpoint, and possible minimal re-ingestion after unexpected shutdowns) and clarified Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~8 minutes Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: defaults Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
72849b6 to
8079262
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: defaults
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
pipeline/inputs/tail.md(1 hunks)
🧰 Additional context used
🪛 GitHub Check: runner / vale
pipeline/inputs/tail.md
[failure] 100-100:
[vale] reported by reviewdog 🐶
[FluentBit.MayMightCan] Use 'can' for permissions or 'might' for possibility.
Raw Output:
{"message": "[FluentBit.MayMightCan] Use 'can' for permissions or 'might' for possibility.", "location": {"path": "pipeline/inputs/tail.md", "range": {"start": {"line": 100, "column": 114}}}, "severity": "ERROR"}
[failure] 98-98:
[vale] reported by reviewdog 🐶
[FluentBit.MayMightCan] Use 'can' for permissions or 'might' for possibility.
Raw Output:
{"message": "[FluentBit.MayMightCan] Use 'can' for permissions or 'might' for possibility.", "location": {"path": "pipeline/inputs/tail.md", "range": {"start": {"line": 98, "column": 138}}}, "severity": "ERROR"}
[failure] 98-98:
[vale] reported by reviewdog 🐶
[FluentBit.Latin] Use 'for example' instead of 'e.g.,'.
Raw Output:
{"message": "[FluentBit.Latin] Use 'for example' instead of 'e.g.,'.", "location": {"path": "pipeline/inputs/tail.md", "range": {"start": {"line": 98, "column": 26}}}, "severity": "ERROR"}
🪛 LanguageTool
pipeline/inputs/tail.md
[style] ~98-~98: ‘lag behind’ might be wordy. Consider a shorter alternative.
Context: ...ivery. The database offset may slightly lag behind the actual processed position if an **u...
(EN_WORDINESS_PREMIUM_LAG_BEHIND)
8079262 to
dfca97e
Compare
|
Following our discussion, I have updated the documentation to address the data reliability behavior during unexpected shutdowns (related to fluent/fluent-bit#11269). Summary of changes:
This addition ensures that users are aware of this behavior as a known corner case, as suggested. Thanks! |
esmerel
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks pretty good to me also
This commit adds a 'Data Reliability and Recovery' hint to the Tail input plugin documentation. It clarifies the behavior of the database offset mechanism during unexpected shutdowns (e.g., system crash, power loss). Specifically, it explains that while Fluent Bit guarantees at-least-once delivery, there is a possibility of slight offset lag and minimal data duplication upon recovery. This ensures users understand that no data is lost even in these scenarios. refs: fluent/fluent-bit#11269 Signed-off-by: jinyong.choi <[email protected]>
dfca97e to
c017872
Compare
This commit adds a 'Data Reliability and Recovery' hint to the Tail input plugin documentation.
It clarifies the behavior of the database offset mechanism during unexpected shutdowns (e.g., system crash, power loss). Specifically, it explains that while Fluent Bit guarantees at-least-once delivery, there is a possibility of slight offset lag and minimal data duplication upon recovery. This ensures users understand that no data is lost even in these scenarios.
fluent/fluent-bit#11269
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.