Skip to content

Conversation

tomekwilk
Copy link

@tomekwilk tomekwilk commented Jan 2, 2025

Matching fluent/fluent-bit PR fluent/fluent-bit#9791

Copy link
Contributor

@lockewritesdocs lockewritesdocs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution @tomekwilk! Suggested a minor edit, but LGTM otherwise.

| sas\_token | Specify the Azure Storage shared access signatures to authenticate against the service. This configuration property is mandatory when `auth_type` is `sas`. | |
| container\_name | Name of the container that will contain the blobs. This configuration property is mandatory | |
| blob\_type | Specify the desired blob type. Fluent Bit supports `appendblob` and `blockblob`. | appendblob |
| log\_key | By default, the whole log record will be sent to blob storage. If you specify a key name with this option, then only the value of that key will be sent. | |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
| log\_key | By default, the whole log record will be sent to blob storage. If you specify a key name with this option, then only the value of that key will be sent. | |
| log\_key | By default, the entire log record is sent to blob storage. If you specify a key name with this option, only the value of that key is sent. | |

@khalillilahk
Copy link

Hey @tomekwilk @lockewritesdocs,
Just wanted to follow up on this PR, are there any issues preventing it from getting merged?

@eschabell eschabell self-assigned this Oct 21, 2025
@eschabell
Copy link
Collaborator

@khalillilahk these doc changes can only be applied once the code PR fluent/fluent-bit#9791 is merged, I've nudged the code owner over there as there are changes needed to that PR.

@eschabell
Copy link
Collaborator

@tomekwilk I've nudged you on the code PR fluent/fluent-bit#9791, once that's merged this one is ready to go if you fix the conflicts in this doc PR.

@eschabell eschabell added conflict Waiting on conflict to be resolved by contributor waiting-for-user Waiting for user/contributors feedback or requested changes labels Oct 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

conflict Waiting on conflict to be resolved by contributor waiting-for-user Waiting for user/contributors feedback or requested changes waiting-on-code-merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants